Fix LinkedList removeAt() #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.added base case for removeAt(1) 2.switched assigment on line #138 where previous and current where pointing to the same node
ashokdey
added
bug-fix
enhancement
ashokdey
approved these changes
Oct 18, 2019
ashokdey
requested changes
Oct 18, 2019
There was a problem hiding this comment.
Hello @TheKingSombrero, thanks for the PR and it's good to see you took an interest. However, there are a few things that you have to see:
- ESLint rules should not break
- Remove methods should always return a node (and the next should be null)
- Please go through the issue details here: removeAt function in linked-list #83
- The removal method should work as an array
Thanks!
| } | ||
|
|
||
| previous.next = address.next; | ||
| console.log(address.next) |
There was a problem hiding this comment.
No console.log() in the final push to master
ashokdey
reviewed
Oct 18, 2019
passes eslint and matches and enforced strict equality for some reason it wasn't running in node with it
rahulrana95
reviewed
Oct 19, 2019
|
|
||
| if (index >= this.length()) { | ||
| if (index === 0) { | ||
| let returnNode=this.head; |
rahulrana95
reviewed
Oct 19, 2019
| let returnNode=this.head; | ||
| this.head=this.head.next; | ||
| this.size -= 1; | ||
| return returnNode; |
There was a problem hiding this comment.
if (!this.head) {
this.head = node;
this.tail = node;
return node;
}If you do not make it null it will contain the full list
rahulrana95
reviewed
Oct 19, 2019
| this.size -= 1; | ||
| return returnNode; | ||
| } | ||
| if (index >= this.size) { |
rahulrana95
reviewed
Oct 19, 2019
| previous = address; | ||
| address = address.next; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.added base case for removeAt(1)
2.switched assigment on line #138 where previous and current where pointing to the same node