Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Binary Tree #96

Merged
merged 4 commits into from
Oct 17, 2019
Merged

Added Binary Tree #96

merged 4 commits into from
Oct 17, 2019

Conversation

ashokdey
Copy link
Member

🐔 What's new?

  • Binary Tree (!BST)
    • Create a BT using Level Order Array

@ashokdey ashokdey added enhancement New feature or request new-data-structure labels Oct 17, 2019
@ashokdey ashokdey requested a review from TheSTL October 17, 2019 11:51
@ashokdey ashokdey self-assigned this Oct 17, 2019
TheSTL
TheSTL reviewed Oct 17, 2019
View reviewed changes
src/_DataStructures_/Trees/BinaryTree/index.js Outdated

class BinaryTree {
constructor(arr) {
if (!Array.isArray(arr)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check if array is empty or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got you!

TheSTL
TheSTL approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@TheSTL TheSTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ashokdey ashokdey merged commit 9e01c43 into master Oct 17, 2019
@ashokdey ashokdey deleted the problems branch October 18, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSTL TheSTL TheSTL approved these changes

Assignees

@ashokdey ashokdey

Labels
enhancement New feature or request new-data-structure review-complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashokdey @TheSTL