Add Ternary search #76
Conversation
|
@Kyle-Ski, we are not getting your commits please setup git in your system properly |
|
@ashokdey I've fixed the issue with the commits, please let me know if you are able to see them correctly |
| } else if(arr.indexOf(key) == - 1){ | ||
| return null; |
There was a problem hiding this comment.
Can you remove this line of code because arr.indexOf take O(n) time .
| return lowMiddle; | ||
| } else if(key === arr[highMiddle]){ | ||
| return highMiddle; | ||
| } else if(key < arr[highMiddle]){ |
There was a problem hiding this comment.
Code should be } else if(key < arr[lowMiddle]){
| } else if(key === arr[highMiddle]){ | ||
| return highMiddle; | ||
| } else if(key < arr[highMiddle]){ | ||
| return ternarySearchRecursive(arr, low, lowMiddle, key); |
There was a problem hiding this comment.
return ternarySearchRecursive(arr, low, lowMiddle-1, key);
| } else if(key < arr[highMiddle]){ | ||
| return ternarySearchRecursive(arr, low, lowMiddle, key); | ||
| } else if(key > arr[lowMiddle] && key < arr[highMiddle]){ | ||
| return ternarySearchRecursive(arr, lowMiddle, highMiddle, key); |
There was a problem hiding this comment.
return ternarySearchRecursive(arr, lowMiddle+1, highMiddle-1, key);
| } else if(arr.indexOf(key) == - 1){ | ||
| return null; | ||
| } else { | ||
| return ternarySearchRecursive(arr, highMiddle, high, key); |
There was a problem hiding this comment.
return ternarySearchRecursive(arr, highMiddle+1, high, key);
…ests now correct
|
@TheSTL I've made the changes you requested, do the new variable names on the non-recursive function help? |
| } | ||
|
|
||
| function ternarySearchRecursive(arr, low, high, key){ | ||
| if(high > low){ |
| } else if(key === arr[high]){ | ||
| return high; |
There was a problem hiding this comment.
Can you remove this extra IF condition?
|
@TheSTL Thanks for the help fixing the recursive function! I also commented like you suggested. |
Attempt to solve issue #72