Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to postfix expression evaluation function. Resolves #34 #59

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

vobango
Copy link

@vobango vobango commented Oct 9, 2019

The added tests verify what the function is currently able to do, coverage is 100%.
I didn't cover the case of too few number arguments (i.e '1-*') because it returns NaN and I'm not sure if this is the desired output.

@ashokdey
Copy link
Member

ashokdey commented Oct 9, 2019

@TheSTL let @vobango know what should be the desired output and accordinly he can write tests. If tests fail, a new issue has to be opened to rectify the behavior.

@TheSTL
Copy link
Member

TheSTL commented Oct 10, 2019

Hello @vobango .
I have created a new issue for this problem. Thanks for pointing it out. I'am merging this PR and when issue resolved than you can write test for this.

@TheSTL TheSTL merged commit 5c826c5 into knaxus:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants