Skip to content

Add fibonacci tests #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/_Classics_/fibonacci/fibonacci.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
const { fibonacci, fibonacciMemoized, fibonacciTabular } = require('.');

describe('Find the Fibonacci Sum for a given index', () => {

it('should return 1 when index is 0', () => {
expect(fibonacci(0)).toEqual(1);
expect(fibonacciMemoized(0)).toEqual(1);
expect(fibonacciTabular(0)).toEqual(1); //failing
});

it('should return 1 when index is 1', () => {
expect(fibonacci(1)).toEqual(1);
expect(fibonacciMemoized(1)).toEqual(1);
expect(fibonacciTabular(1)).toEqual(1);
});

it('should return 1 when index is 2', () => {
expect(fibonacci(2)).toEqual(1);
expect(fibonacciMemoized(2)).toEqual(1);
expect(fibonacciTabular(2)).toEqual(1);
});

it('should return 55 when index is 10', () => {
expect(fibonacci(10)).toEqual(55);
expect(fibonacciTabular(10)).toEqual(55);
expect(fibonacciMemoized(10)).toEqual(55);
});

it('should return 1.7147923024004204e+106 when index is 510', () => {
expect(fibonacciMemoized(510)).toEqual(1.7147923024004204e+106);
expect(fibonacciTabular(510)).toEqual(1.7147923024004204e+106);
});

it('should return 1 when index is negative', () => {
expect(fibonacci(-1)).toEqual(1);
expect(fibonacciMemoized(-1)).toEqual(1);
expect(fibonacciTabular(-1)).toEqual(1); //failing
});
});
8 changes: 7 additions & 1 deletion src/_Classics_/fibonacci/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function fibonacciMemoized(index, cache) {
/**
* Using the bottom up approach, also known as tabular method
*/

// @TODO: Handle this function for indexes 0 and negative numbers
function fibonacciTabular(n) {
const table = [0, 1];

Expand All @@ -49,6 +49,12 @@ function fibonacciTabular(n) {
return table[n];
}

module.exports = {
fibonacci,
fibonacciMemoized,
fibonacciTabular
}

// const number = 50;

// console.log(`Fib normal - ${fibonacci(number)}`);
Expand Down