Skip to content

implement 2 stacks using 1 array #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

implement 2 stacks using 1 array #35

wants to merge 3 commits into from

Conversation

ashokdey
Copy link
Member

@ashokdey ashokdey commented Oct 6, 2019

🏖 What's inside?

So I went ahead to add a new problem in the Stack section.

  • The implementation is not regular because it does not deal with a fixed size array
  • I doubt that I may not have covered all the edge cases
  • In terms of optimization also, I feel there is a scope of improvement.

@ashokdey ashokdey requested a review from TheSTL October 6, 2019 07:35
@ashokdey ashokdey self-assigned this Oct 6, 2019
@ashokdey ashokdey added the invalid This doesn't seem right label Oct 6, 2019
@ashokdey
Copy link
Member Author

ashokdey commented Oct 6, 2019

Since insertions and deletions are going O(n) which is breaking the rules of Stack, this implementation is invalid.

@ashokdey ashokdey closed this Oct 6, 2019
@ashokdey ashokdey added the bug Something isn't working label Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right new problem strict-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant