Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests & fix for "find-2-nums-adding-to-n" #19

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Unit tests & fix for "find-2-nums-adding-to-n" #19

merged 1 commit into from
Oct 3, 2019

Conversation

mattstates
Copy link
Contributor

@mattstates mattstates commented Oct 3, 2019

What's Inside?

  • Add unit tests for find-2-nums-adding-to-n
  • Fix findTwoNumsAddingToN2() so it only returns one pair

@ashokdey ashokdey requested a review from TheSTL October 3, 2019 20:56
@ashokdey ashokdey self-requested a review October 3, 2019 20:57
Copy link
Member

@ashokdey ashokdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mattstates 👍

@ashokdey ashokdey changed the title Add unit tests for "find-2-nums-adding-to-n". Fix findTwoNumsAddingTo… Unit tests & fix for "find-2-nums-adding-to-n" Oct 3, 2019
@ashokdey
Copy link
Member

ashokdey commented Oct 3, 2019

Hi @mattstates, thanks for the PR, it's a good fix and UT. However, let's wait for the 2nd approval. Meanwhile, if you find this repo helpful then you can go ahead to ⭐️ and share it on social media for others!

Happy Hacktober Fest 🍸

@ashokdey ashokdey merged commit e7f1166 into knaxus:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants