Balanced parentheses problem added #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adarshaacharya
changed the title
ashokdey
requested changes
Jul 26, 2020
Comment on lines
+15
to
+21
| if (prev < 0) return prev; | ||
|
|
||
| if (char === '(') return ++prev; | ||
|
|
||
| if (char === ')') return --prev; | ||
|
|
||
| return prev; |
There was a problem hiding this comment.
Can we use a switch case here?
There was a problem hiding this comment.
I think switch case isn't needed here since we have to check two variables char & prev here. can i use ternary operator instead ?
There was a problem hiding this comment.
Something like this
return !string.split('').reduce((prev, char) => {
const result = prev < 0 ? prev : char === '(' ? ++prev : char === ')' ? --prev : prev;
return result;
}, 0);There was a problem hiding this comment.
The above snippet is not readable enough
There was a problem hiding this comment.
so, if else pattern will be fine right ? switch case will add more code since we have to check cases for prev & char.
| */ | ||
|
|
||
| function balancedParantheses(string) { | ||
| return !string.split('').reduce(function(prev, char) { |
There was a problem hiding this comment.
How about an arrow function here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue no : #166
Solving balanced paratheses problem using reduce() method in ES6.