Skip to content

fix: linked list removeAt() #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2019
Merged

fix: linked list removeAt() #157

merged 3 commits into from
Nov 11, 2019
+32 −5

Conversation

ashokdey
Copy link
Member

@ashokdey ashokdey commented Nov 8, 2019 •
edited
Loading

🏷 What's Inside?

  • Fix for LinkedList removeAt()

YahavArm and others added 2 commits October 17, 2019 23:16
@YahavArm
Fix LinkedList removeAt()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d9ab18c 
1.added base case for removeAt(1)
2.switched assigment on line #138 where previous and current where pointing to the same node
@ashokdey
fix: removeAt() work as an array and returns a Node
9084503
@ashokdey ashokdey requested a review from TheSTL November 8, 2019 16:20
@ashokdey ashokdey self-assigned this Nov 8, 2019
TheSTL
TheSTL reviewed Nov 9, 2019
View reviewed changes
TheSTL
TheSTL reviewed Nov 9, 2019
View reviewed changes
@TheSTL TheSTL merged commit f6f00e7 into master Nov 11, 2019
@ashokdey ashokdey deleted the ll-remoteAt branch November 26, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSTL TheSTL

Assignees

@ashokdey ashokdey

Labels
bug-fix changes-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashokdey @TheSTL @YahavArm