Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heaps #156

Merged
merged 16 commits into from
Nov 5, 2019
Merged

Heaps #156

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
15e262f
update: entry in TOC.md
ashokdey Nov 3, 2019
c2f5934
fix: used pop() instead of splice()
ashokdey Nov 4, 2019
5338710
update: added MinHeap, support for collection in constructor
ashokdey Nov 4, 2019
16006e0
fix: order of length check in remove()
ashokdey Nov 4, 2019
7b958e9
fix & update: handled case of min/max element 0, fixes in tests
ashokdey Nov 4, 2019
6ced3ff
update: entry in TOC.md
ashokdey Nov 4, 2019
042670a
update: added k smallest elements problem
ashokdey Nov 4, 2019
f9f2cfc
update: added K largest array elements
ashokdey Nov 4, 2019
a03369c
fix: repo name change
ashokdey Nov 4, 2019
875f6ca
fix: repo placement
ashokdey Nov 4, 2019
4f5f695
cleanup
ashokdey Nov 4, 2019
1e2a548
update: entry in TOC.md
ashokdey Nov 4, 2019
c2d8c12
fix: remove will return and remove the element from the heap
ashokdey Nov 4, 2019
c3e44df
update: README makeover
ashokdey Nov 5, 2019
2daa87d
fixes: README changes
ashokdey Nov 5, 2019
2c1011a
update: Added links in README
ashokdey Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: used pop() instead of splice()
  • Loading branch information
@ashokdey
ashokdey committed Nov 4, 2019
commit c2f5934f28099c7bb7174b146ead275b9c94fc80
7 changes: 3 additions & 4 deletions src/_DataStructures_/Heaps/MaxHeap/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,25 +14,24 @@ class MaxHeap {
return this.heap[0] || null;
}

// eslint-disable-next-line consistent-return
remove() {
// return the element at the root
const max = this.heap[0] || null;
if (this.heap.length > 1) {
// move the leaf to the root
this.heap[0] = this.heap[this.heap.length - 1];
this.heap.splice(this.heap.length - 1, 1);
this.heap.pop();
// restore the heapify property
// eslint-disable-next-line no-underscore-dangle
this.__heapify(0);
return max;
}

if (this.heap.length === 1) {
this.heap.splice(this.heap.length - 1, 1);
this.heap.pop();
return max;
}

return max;
}

__heapify(index) {
Expand Down