add test for bottom view binary tree #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSTL
requested changes
Oct 26, 2019
There was a problem hiding this comment.
hi @christian-fei can you cover following test cases where Btree is null?
|
@TheSTL updated the tests, thanks |
TheSTL
reviewed
Oct 26, 2019
| btree = new BinaryTree([1, 2, 3, 4, 5, 6]); | ||
| }); | ||
|
|
||
| it('Determines the bottom view of a binary tree', () => { |
There was a problem hiding this comment.
'Determines the bottom view of a binary tree' -> Should determines the bottom view of a binary tree
It's all about Behavior Driven Testing, hence it starts with or contains should
TheSTL
reviewed
Oct 26, 2019
| it('Determines the bottom view of a binary tree', () => { | ||
| expect(bottomView(btree)).toEqual([6, 2, 3, 4]); | ||
| }); | ||
| it('handles null binary tree', () => { |
There was a problem hiding this comment.
'handles null binary tree' -> Should handles null binary tree
TheSTL
requested changes
Oct 26, 2019
There was a problem hiding this comment.
Learn today how to write unit test title.
Sorry for pointing it out now. @christian-fei
TheSTL
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should help with #146
please let me know what you think