Adding bottom view binary tree problem solution #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Solution based on https://www.geeksforgeeks.org/bottom-view-binary-tree/ - Modified `.gitignore` to ignore Visual Studio's files
|
Fixes #120 |
|
Hi @karimelazzouni you can use |
|
Hi @TheSTL , I implemented the changes. If you have no more comments let's merge this. |
TheSTL
reviewed
Oct 24, 2019
package.json
Outdated
Comment on lines
23
to
24
| }, | ||
| "dependencies": {} |
TheSTL
reviewed
Oct 24, 2019
| } | ||
| } | ||
|
|
||
| return hdToNodeValue.values(); |
There was a problem hiding this comment.
It should return an array instead of Iterator @karimelazzouni
TheSTL
requested changes
Oct 24, 2019
- Removed unnecessary dependencies in `packages.json` - Changed returned value to array
TheSTL
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BinaryTreeas a parameter and returns the bottom view as an integer array.gitignoreto ignore Visual Studio's files