Add unit tests for suffix tree #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @faergeek can you add few more cases ? Now test cases are weak. |
|
To be honest, I am not sure which test cases would not be weak. May be I just don't get it. Do you have some advice? |
|
Thanks! I added these cases. BTW why is there separate method for constructing suffix tree? Why it isn't done in constructor? |
|
More than a month passed. Do I stiil need to fix something here? |
|
Sorry ,I have been busy lately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87
Not sure if these tests are enough. Can't think of something more. Can you take a look?