KMP classic algorithm and unit tests #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSTL
reviewed
Oct 23, 2019
| /* * | ||
| * The time complexity of KMP algorithm is O(n) in the worst case | ||
| * Example use case: Pattern = ABCABCACA Text = AAABCBAABCABCACACABBCA | ||
| * LPSArray = [ 0, 0, 0, 1, 2, 3, 4, 0, 1 ] |
There was a problem hiding this comment.
It should be LPSArray = [ 0, 1, 0, 0, 1, 0 ]
There was a problem hiding this comment.
Hi @TheSTL the pattern had been updated to ABCABCACA. I feel this is a more intuitive example. I believe [ 0, 0, 0, 1, 2, 3, 4, 0, 1 ] to be the correct LPS, if there are any more queries or amendments you would like to be made, I’ll updage the PR as appropriate. Cheers.
There was a problem hiding this comment.
I think this example is more understandable from previous one to compute LPS.
TheSTL
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: #124
Added KMP algorithm to classics folder, along with a series of unit tests to bring the file coverage up to 100%.
Updated file to keep in line with eslint rules.
Added comments and time complexity of the KMP pattern matching algorithm.
Added example use case in file preamble.