Add Unit Test For - Trie search string #106 #110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSTL
approved these changes
Oct 19, 2019
TheSTL
requested changes
Oct 19, 2019
There was a problem hiding this comment.
Hi @reshmisaji test cases are weak. Can you work more on it?
For example :
- Insert
abcdefg - Insert
abcklf - Insert
dflkg - Insert
dflkghi - Search
dflkghi - Search
dflkghik
ashokdey
requested changes
Oct 24, 2019
Comment on lines
+31
to
+34
| it('Should return false when search is called without a key', () => { | ||
| const result = newTrie.search(); | ||
| expect(result).toEqual(false); | ||
| }); |
Comment on lines
+35
to
+39
|
|
||
| it('Should return false when searched for a key which is not yet added', () => { | ||
| const result = newTrie.search('abc'); | ||
| expect(result).toEqual(false); | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #106
Hacktoberfest