-
Notifications
You must be signed in to change notification settings - Fork 55
Issues 109 #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Issues 109 #132
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
72d2a5c
Added support for Access Keys.
BlackVegetable 7104030
updated README with access keys
BlackVegetable 3a8ebda
minor fixes
BlackVegetable 55953d4
Fixed Travis test dependencies
BlackVegetable cba39a8
Version 0.5.0
BlackVegetable abfa25c
Updated utils version string
BlackVegetable 8ba17b8
Added Access Key helpers
BlackVegetable 966fff3
better docs
BlackVegetable a6aed95
docs update from review
BlackVegetable 734b111
plus initial test
BlackVegetable 2e72d86
Actually update changelog
BlackVegetable a672c89
fixed 2.6 compat with order_by test
BlackVegetable 1fc2b11
+staticmethod decorator
BlackVegetable bd88aee
Deprecate 2.6 and 3.3
BlackVegetable File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a deliberate decision made to put this right in
__init__.pyinstead of doing something liked the Saved/Cached Query Interface? Just curious.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The answer to all of these was, for the most part, to avoid deviating from the existing patterns I saw. The other answer is that I wanted to create the simplest path for users to run Access Key operations, which meant hiding the client (shoving it in
__init__like the basic queries) but also allowing them to work with a specific client in case they have multiple projects they are running in a single Python process.To be honest though, I made that decision pretty lightly and could be persuaded to move it into its own interface. I don't like how monolithic that file has become.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ambivalent, so whatever feels right to you.