Ensure MYSQL port is always evaluated as integer #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For certain versions of MYSQL it will fail to connect if the port is enterprated as a string and will throw a status 500 error when connecting to the database ```python # Error occurs here for reference if others encounter the same issue cur = mysql.connection.cursor() ```
|
Thanks for making this PR. In my auth/server.py. I casted the type of the mysql port to an int, and solved an issue regarding connecting to mysql. server.config["MYSQL_PORT"] = int(os.environ.get("MYSQL_PORT")) # type:int |
Yakult0815
approved these changes
Feb 19, 2023
Yakult0815
left a comment
Yakult0815
left a comment
There was a problem hiding this comment.
thanks for this PR, I can confirm the error is thrown running versions:
Flask==2.2.2
Flask-MySQLdb==1.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain versions of MYSQL it will fail to connect if the port is enterprated as a string and will throw a status 500 error when connecting to the database