Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] require-default-props: report when required props have default param value #3785

Merged
merged 1 commit into from
Jul 20, 2024
Merged

[Fix] require-default-props: report when required props have default param value #3785

merged 1 commit into from
Jul 20, 2024

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented Jul 18, 2024

Closes #3720

@akulsr0 akulsr0 changed the title [Fix]require-default-props: report when required props have default value [Fix]require-default-props: report when required props have default param value Jul 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.75%. Comparing base (a08cb93) to head (a4b0bbc).

Files Patch % Lines
lib/rules/require-default-props.js 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3785      +/-   ##
==========================================
+ Coverage   97.62%   97.75%   +0.12%     
==========================================
  Files         132      135       +3     
  Lines        9697     9715      +18     
  Branches     3522     3527       +5     
==========================================
+ Hits         9467     9497      +30     
+ Misses        230      218      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb ljharb force-pushed the akul/issue-3720 branch from 0ddcd35 to a4b0bbc Compare July 19, 2024 22:14
@ljharb ljharb merged commit a4b0bbc into jsx-eslint:master Jul 20, 2024
344 of 345 checks passed
@ljharb ljharb changed the title [Fix]require-default-props: report when required props have default param value [Fix] require-default-props: report when required props have default param value Jul 20, 2024
@alhugot-azpn alhugot-azpn mentioned this pull request Aug 10, 2024
Merged
@zdr4k zdr4k mentioned this pull request Aug 10, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Aug 10, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Aug 10, 2024
Open
This was referenced Aug 10, 2024
Open
Open
Open
This was referenced Aug 10, 2024
Open
Open
@patooworld patooworld mentioned this pull request Aug 10, 2024
Open
This was referenced Aug 10, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Aug 10, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 10, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Aug 11, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 11, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Aug 11, 2024
Open
@alhugot-azpn alhugot-azpn mentioned this pull request Aug 12, 2024
Closed
@ASISBusiness ASISBusiness mentioned this pull request Aug 16, 2024
Closed
@Exkaleburx Exkaleburx mentioned this pull request Aug 20, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 6, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 16, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 20, 2024
Open
This was referenced Oct 22, 2024
Open
Open
Open
@Loonz206 Loonz206 mentioned this pull request Oct 23, 2024
Open
This was referenced Oct 23, 2024
Open
Open
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 25, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 26, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Oct 26, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 26, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 26, 2024
Open
@Vishesh7797 Vishesh7797 mentioned this pull request Oct 27, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 27, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 27, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 27, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 28, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Oct 31, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Nov 2, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Nov 2, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Nov 3, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Nov 7, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Nov 7, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Nov 11, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: The forbidDefaultForRequired option in the react/require-default-props rule does not work as expected
2 participants
@akulsr0 @ljharb