Skip to content

Fix params blacklist #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2018
Merged

Fix params blacklist #75

merged 1 commit into from
Sep 25, 2018

Conversation

ScottTrenda
Copy link
Collaborator

@ScottTrenda ScottTrenda commented Sep 17, 2018 •
edited
Loading

Fixes a bug where properties of params with the same name as blacklisted copy properties (data, cache, timeout) would be stripped prior to making the HTTP call.

  • - npm test succeeds
  • - Pull request has been squashed into 1 commit
  • - I did NOT commit changes to dist/
  • - Code coverage does not decrease (if any source code was changed)
  • - Appropriate JSDoc comments were updated in source code (if applicable)
  • - Approprate changes to js-data.io docs have been suggested ("Suggest Edits" button)

@ScottTrenda ScottTrenda changed the base branch from master to v2 September 17, 2018 19:30
@ScottTrenda ScottTrenda mentioned this pull request Sep 17, 2018
Merged
6 tasks
@crobinson42 crobinson42 merged commit 8eba267 into js-data:v2 Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottTrenda @crobinson42