Skip to content

Do every erb replacemenet in the same editor.transaction #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Do every erb replacemenet in the same editor.transaction #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions lib/rails-snippets.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
# much love to @eddorre <3 <3
{Range} = require 'atom'
{CompositeDisposable} = require 'atom'

ERB_REGEX = '<%(=?|-?|#?)\s{2}(-?)%>'
# matches the opening bracket
ERB_OPENER_REGEX = '<%[\\=\\#\\-]?'
# matches the closing bracket.
ERB_CLOSER_REGEX = "-?%>"
ERB_OPENING_BRACKET_REGEXP = '<%[\\=\\#\\-]?'
ERB_CLOSING_BRACKET_REGEXP = "-?%>"

module.exports =
config:
Expand All @@ -21,13 +17,13 @@ module.exports =
@subscriptions.add atom.commands.add 'atom-workspace', 'rails-snippets:toggleErb', => @toggleErb()

toggleErb: ->
delegate = @
editor = atom.workspace.getActiveTextEditor()
for selection in editor.getSelections() by 1
hasTextSelected = !selection.isEmpty()
selectedText = selection.getText()
delegate = @
editor.transact ->
for selection in editor.getSelections() by 1
hasTextSelected = !selection.isEmpty()
selectedText = selection.getText()

editor.transact ->
selection.deleteSelectedText()
currentCursor = selection.cursor
# searching for opening and closing brackets
Expand Down Expand Up @@ -55,14 +51,14 @@ module.exports =

# searching in the left range for an opening bracket
foundOpeners = []
editor.getBuffer().scanInRange new RegExp(ERB_OPENER_REGEX, 'g'), leftRange, (result) ->
editor.getBuffer().scanInRange new RegExp(ERB_OPENING_BRACKET_REGEXP, 'g'), leftRange, (result) ->
foundOpeners.push result.range
# if found, setting a range for it, using the last match - the rightmost bracket found
opener = foundOpeners[foundOpeners.length - 1] if foundOpeners

# searching in the right range for an opening bracket
foundClosers = []
editor.getBuffer().scanInRange new RegExp(ERB_CLOSER_REGEX, 'g'), rightRange, (result) ->
editor.getBuffer().scanInRange new RegExp(ERB_CLOSING_BRACKET_REGEXP, 'g'), rightRange, (result) ->
foundClosers.push result.range
# if found, setting a new range, using the first match - the leftmost bracket found
closer = foundClosers[0] if foundClosers
Expand Down