Skip to content

JDK11 support #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

JDK11 support #37

wants to merge 4 commits into from

Conversation

DMLoy
Copy link

@DMLoy DMLoy commented Jan 5, 2019

This would make this a Java 11 project.

test and spring-boot:run all work with what I've tested.

#17 was the inspiration. But JDK11 is LTS.

@mgh87
Copy link

mgh87 commented Jan 6, 2019

Due to the reformatting the differences are really hard to spot.
Is there a reason, why you would downgrade <build-plugin.jacoco.version> from 0.8.2 to 0.8.1?

@DMLoy
Copy link
Author

DMLoy commented Jan 7, 2019

@mgh87
Good catch; I was trying to run down the surefire bug and saw someone suggest this. I'll fix the fix.

If you hit Diff Settings -> Hide White Space Changes -> Apply

@mgh87
Copy link

mgh87 commented Jan 8, 2019

Thanks for pointing out the whitespace filter. (Wasn't aware of this feature).
Have you thought about profiles and jdk activations to create a dynamic binding based on the jdk set within the shells environment?

That would keep it stable for 8 and 11, since 11 is not that wide spread yet.

@mgh87
Copy link

mgh87 commented Jan 8, 2019

https://github.com/mgh87/spring-boot-vuejs/tree/java11_support

Here would be my change to a profile approach. GitHub, didn't let me create a pull request to your repository, for whatever reason.

++ some simplification.
++ https update
@coveralls
Copy link

Pull Request Test Coverage Report for Build 120

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.103%

Totals Coverage Status
Change from base Build 112: 0.0%
Covered Lines: 27
Relevant Lines: 29

💛 - Coveralls

@DMLoy
Copy link
Author

DMLoy commented Jan 11, 2019

@jonashackt @mgh87 comments welcome!

@jonashackt
Copy link
Owner

Hey @DMLoy & @mgh87 - sorry for the delay, but I was really busy - and didn't want to tackle issues, that would have been solved in the future (like extra surefire configuration and so on). Now with #45 - and just using TravisCI building on all major JDKs, this should be done right now. If you'd like to test, it would be great. Closing this now.

@jonashackt jonashackt closed this Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants