Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency json5 [security] - autoclosed #273

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 31, 2022

Mend Renovate

This PR contains the following updates:

Package Change
json5 2.2.0 -> 2.2.2
json5 1.0.1 -> 1.0.2

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

CVE-2022-46175

The parse method of the JSON5 library before and including version 2.2.1 does not restrict parsing of keys named __proto__, allowing specially crafted strings to pollute the prototype of the resulting object.

This vulnerability pollutes the prototype of the object returned by JSON5.parse and not the global Object prototype, which is the commonly understood definition of Prototype Pollution. However, polluting the prototype of a single object can have significant security impact for an application if the object is later used in trusted operations.

Impact

This vulnerability could allow an attacker to set arbitrary and unexpected keys on the object returned from JSON5.parse. The actual impact will depend on how applications utilize the returned object and how they filter unwanted keys, but could include denial of service, cross-site scripting, elevation of privilege, and in extreme cases, remote code execution.

Mitigation

This vulnerability is patched in json5 v2.2.2 and later. A patch has also been backported for json5 v1 in versions v1.0.2 and later.

Details

Suppose a developer wants to allow users and admins to perform some risky operation, but they want to restrict what non-admins can do. To accomplish this, they accept a JSON blob from the user, parse it using JSON5.parse, confirm that the provided data does not set some sensitive keys, and then performs the risky operation using the validated data:

const JSON5 = require('json5');

const doSomethingDangerous = (props) => {
  if (props.isAdmin) {
    console.log('Doing dangerous thing as admin.');
  } else {
    console.log('Doing dangerous thing as user.');
  }
};

const secCheckKeysSet = (obj, searchKeys) => {
  let searchKeyFound = false;
  Object.keys(obj).forEach((key) => {
    if (searchKeys.indexOf(key) > -1) {
      searchKeyFound = true;
    }
  });
  return searchKeyFound;
};

const props = JSON5.parse('{"foo": "bar"}');
if (!secCheckKeysSet(props, ['isAdmin', 'isMod'])) {
  doSomethingDangerous(props); // "Doing dangerous thing as user."
} else {
  throw new Error('Forbidden...');
}

If the user attempts to set the isAdmin key, their request will be rejected:

const props = JSON5.parse('{"foo": "bar", "isAdmin": true}');
if (!secCheckKeysSet(props, ['isAdmin', 'isMod'])) {
  doSomethingDangerous(props);
} else {
  throw new Error('Forbidden...'); // Error: Forbidden...
}

However, users can instead set the __proto__ key to {"isAdmin": true}. JSON5 will parse this key and will set the isAdmin key on the prototype of the returned object, allowing the user to bypass the security check and run their request as an admin:

const props = JSON5.parse('{"foo": "bar", "__proto__": {"isAdmin": true}}');
if (!secCheckKeysSet(props, ['isAdmin', 'isMod'])) {
  doSomethingDangerous(props); // "Doing dangerous thing as admin."
} else {
  throw new Error('Forbidden...');
}

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Dec 31, 2022

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: frontend/package-lock.json
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: frontend@4.0.0
npm WARN Found: @vue/cli-service@4.5.13
npm WARN node_modules/@vue/cli-service
npm WARN   dev @vue/cli-service@"5.0.1" from the root project
npm WARN   7 more (@vue/cli-plugin-babel, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @vue/cli-service@"^3.0.0 || ^4.0.0-0" from @vue/cli-plugin-babel@4.5.13
npm WARN node_modules/@vue/cli-plugin-babel
npm WARN   dev @vue/cli-plugin-babel@"4.5.13" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: frontend@4.0.0
npm WARN Found: @vue/cli-service@4.5.13
npm WARN node_modules/@vue/cli-service
npm WARN   dev @vue/cli-service@"5.0.1" from the root project
npm WARN   7 more (@vue/cli-plugin-babel, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @vue/cli-service@"^3.0.0 || ^4.0.0-0" from @vue/cli-plugin-eslint@4.5.19
npm WARN node_modules/@vue/cli-plugin-eslint
npm WARN   dev @vue/cli-plugin-eslint@"4.5.19" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: frontend@4.0.0
npm WARN Found: @vue/cli-service@4.5.13
npm WARN node_modules/@vue/cli-service
npm WARN   dev @vue/cli-service@"5.0.1" from the root project
npm WARN   7 more (@vue/cli-plugin-babel, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @vue/cli-service@"^3.0.0 || ^4.0.0-0" from @vue/cli-plugin-router@4.5.13
npm WARN node_modules/@vue/cli-plugin-router
npm WARN   dev @vue/cli-plugin-router@"4.5.13" from the root project
npm WARN   1 more (@vue/cli-service)
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: frontend@4.0.0
npm WARN Found: @vue/cli-service@4.5.13
npm WARN node_modules/@vue/cli-service
npm WARN   dev @vue/cli-service@"5.0.1" from the root project
npm WARN   7 more (@vue/cli-plugin-babel, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @vue/cli-service@"^3.0.0 || ^4.0.0-0" from @vue/cli-plugin-typescript@4.5.13
npm WARN node_modules/@vue/cli-plugin-typescript
npm WARN   dev @vue/cli-plugin-typescript@"4.5.13" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: frontend@4.0.0
npm WARN Found: @vue/cli-service@4.5.13
npm WARN node_modules/@vue/cli-service
npm WARN   dev @vue/cli-service@"5.0.1" from the root project
npm WARN   7 more (@vue/cli-plugin-babel, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @vue/cli-service@"^3.0.0 || ^4.0.0-0" from @vue/cli-plugin-vuex@4.5.13
npm WARN node_modules/@vue/cli-plugin-vuex
npm WARN   dev @vue/cli-plugin-vuex@"4.5.13" from the root project
npm WARN   1 more (@vue/cli-service)
npm notice 
npm notice New major version of npm available! 8.19.3 -> 9.2.0
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0>
npm notice Run `npm install -g npm@9.2.0` to update!
npm notice 
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: frontend@4.0.0
npm ERR! Found: @vue/cli-service@5.0.1
npm ERR! node_modules/@vue/cli-service
npm ERR!   dev @vue/cli-service@"5.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @vue/cli-service@"^3.0.0 || ^4.0.0-0" from @vue/cli-plugin-router@4.5.13
npm ERR! node_modules/@vue/cli-plugin-router
npm ERR!   dev @vue/cli-plugin-router@"4.5.13" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/renovate-cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2023-01-07T04_49_03_945Z-debug-0.log

@renovate renovate bot changed the title chore(deps): update dependency json5 to 2.2.2 [security] chore(deps): update dependency json5 to 2.2.2 [security] - autoclosed Jan 3, 2023
@renovate renovate bot closed this Jan 3, 2023
@renovate renovate bot deleted the renovate/npm-json5-vulnerability branch January 3, 2023 18:15
@renovate renovate bot changed the title chore(deps): update dependency json5 to 2.2.2 [security] - autoclosed chore(deps): update dependency json5 to 2.2.2 [security] Jan 6, 2023
@renovate renovate bot reopened this Jan 6, 2023
@renovate renovate bot restored the renovate/npm-json5-vulnerability branch January 6, 2023 14:40
@renovate renovate bot force-pushed the renovate/npm-json5-vulnerability branch from 2e5ef1b to 7b5fea1 Compare January 6, 2023 18:11
@renovate renovate bot changed the title chore(deps): update dependency json5 to 2.2.2 [security] chore(deps): update dependency json5 to 1.0.2 [security] Jan 6, 2023
@renovate renovate bot changed the title chore(deps): update dependency json5 to 1.0.2 [security] chore(deps): update dependency json5 [security] Jan 7, 2023
@renovate renovate bot changed the title chore(deps): update dependency json5 [security] chore(deps): update dependency json5 [security] - autoclosed Mar 24, 2023
@renovate renovate bot closed this Mar 24, 2023
@renovate renovate bot deleted the renovate/npm-json5-vulnerability branch March 24, 2023 22:25
@renovate renovate bot changed the title chore(deps): update dependency json5 [security] - autoclosed chore(deps): update dependency json5 [security] Mar 27, 2023
@renovate renovate bot reopened this Mar 27, 2023
@renovate renovate bot changed the title chore(deps): update dependency json5 [security] chore(deps): update dependency json5 [security] - autoclosed Mar 27, 2023
@renovate renovate bot closed this Mar 27, 2023
@renovate renovate bot changed the title chore(deps): update dependency json5 [security] - autoclosed chore(deps): update dependency json5 [security] Mar 27, 2023
@renovate renovate bot reopened this Mar 27, 2023
@renovate renovate bot restored the renovate/npm-json5-vulnerability branch March 27, 2023 14:43
@renovate renovate bot changed the title chore(deps): update dependency json5 [security] chore(deps): update dependency json5 [security] - autoclosed Mar 27, 2023
@renovate renovate bot closed this Mar 27, 2023
@renovate renovate bot deleted the renovate/npm-json5-vulnerability branch March 27, 2023 16:40
@renovate renovate bot changed the title chore(deps): update dependency json5 [security] - autoclosed chore(deps): update dependency json5 [security] Mar 27, 2023
@renovate renovate bot reopened this Mar 27, 2023
@renovate renovate bot restored the renovate/npm-json5-vulnerability branch March 27, 2023 22:58
@renovate renovate bot changed the title chore(deps): update dependency json5 [security] chore(deps): update dependency json5 [security] - autoclosed Mar 28, 2023
@renovate renovate bot closed this Mar 28, 2023
@renovate renovate bot deleted the renovate/npm-json5-vulnerability branch March 28, 2023 00:53
@renovate renovate bot changed the title chore(deps): update dependency json5 [security] - autoclosed chore(deps): update dependency json5 [security] Mar 28, 2023
@renovate renovate bot reopened this Mar 28, 2023
@renovate renovate bot restored the renovate/npm-json5-vulnerability branch March 28, 2023 04:45
@renovate renovate bot changed the title chore(deps): update dependency json5 [security] chore(deps): update dependency json5 [security] - autoclosed Mar 28, 2023
@renovate renovate bot closed this Mar 28, 2023
@renovate renovate bot deleted the renovate/npm-json5-vulnerability branch March 28, 2023 06:23
@renovate renovate bot changed the title chore(deps): update dependency json5 [security] - autoclosed chore(deps): update dependency json5 [security] Mar 28, 2023
@renovate renovate bot reopened this Mar 28, 2023
@renovate renovate bot restored the renovate/npm-json5-vulnerability branch March 28, 2023 08:24
@renovate renovate bot changed the title chore(deps): update dependency json5 [security] chore(deps): update dependency json5 [security] - autoclosed Mar 28, 2023
@renovate renovate bot closed this Mar 28, 2023
@renovate renovate bot deleted the renovate/npm-json5-vulnerability branch March 28, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants