Merge from Netflix #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize OperatorSkipLastTimed
OperatorBuffer
OperatorConcat
…to merge-prs Conflicts: rxjava-core/src/main/java/rx/Observable.java
…nto merge-prs Conflicts: rxjava-core/src/main/java/rx/Observable.java
…-prs Conflicts: rxjava-core/src/main/java/rx/Observable.java
…to merge-prs Conflicts: rxjava-core/src/main/java/rx/Observable.java
…rge-prs Conflicts: rxjava-core/src/main/java/rx/Observable.java
…Java into merge-prs Conflicts: rxjava-core/src/main/java/rx/Observable.java
…erge-prs Conflicts: rxjava-core/src/main/java/rx/Observable.java
…rge-prs Conflicts: rxjava-core/src/main/java/rx/Observable.java
Manual Merge of Several PRs
... oxymoronic commit here ... adding some safety to unsafeSubscribe. ... fixes #1090
…andling Handle Thrown Errors with UnsafeSubscribe
Somehow this got lost in the refactorings over the past few weeks.
…-onCreate Restore ObservableExecutionHook.onCreate
- Fixes #1116 - These should never have been added, the subscribeOn operator already provides this functionality
Remove Ambiguous Subscribe Overloads with Scheduler
Operator Alias: Share
- as per Java 8 Stream naming conventions in discussion #678
As per discussion at #678 Code like this is now supported: ```java Observable.from(1, 2, 3).forEach(System.out::println); Observable.from(1, 2, 3).toBlocking().forEach(System.out::println); ```
Adopt Limit and ForEach Java 8 Naming Conventions
As per discussion at #1224 (comment)
also some improvements to javadocs for share()
…ervable Deprecate toBlockingObservable in favor of toBlocking
SafeSubscriber memory reduction
CompositeSubscription with atomic field updater
Performance increase from 7.7m to 8.8m ops/second Before: Benchmark (size) Mode Samples Mean Mean error Units r.u.PerfTransforms.mapTransformation 1 thrpt 5 7714453.187 362218.633 ops/s r.u.PerfTransforms.mapTransformation 1 thrpt 5 7527144.767 497816.471 ops/s After: Benchmark (size) Mode Samples Mean Mean error Units r.u.PerfTransforms.mapTransformation 1 thrpt 5 8853534.333 183494.242 ops/s r.u.PerfTransforms.mapTransformation 1 thrpt 5 8806958.403 452595.219 ops/s
Remove Subscription Wrapper from Observable.subscribe
For code like `Observable.from(1)` Improve performance from ~3.9m to 4.5+m ops/second Before; ``` r.u.PerfTransforms.flatMapTransformsUsingFrom 1 thrpt 5 3923845.687 46657.660 ops/s r.u.PerfTransforms.flatMapTransformsUsingFrom 1024 thrpt 5 8924.953 1983.161 ops/s r.u.PerfTransforms.flatMapTransformsUsingFrom 1 thrpt 5 3623228.857 490894.492 ops/s r.u.PerfTransforms.flatMapTransformsUsingFrom 1024 thrpt 5 9176.330 923.929 ops/s ``` After: ``` Benchmark (size) Mode Samples Mean Mean error Units r.u.PerfTransforms.flatMapTransformsUsingFrom 1 thrpt 5 4052364.587 100971.234 ops/s r.u.PerfTransforms.flatMapTransformsUsingFrom 1024 thrpt 5 11682.783 496.656 ops/s Benchmark (size) Mode Samples Mean Mean error Units r.u.PerfTransforms.flatMapTransformsUsingFrom 1 thrpt 5 4700583.987 77742.037 ops/s r.u.PerfTransforms.flatMapTransformsUsingFrom 1024 thrpt 5 12588.803 58.935 ops/s ``` Using this test: ``` ../gradlew benchmarks '-Pjmh=-f 1 -tu s -bm thrpt -wi 5 -i 5 -r 5 -prof GC .*PerfTransforms.flatMapTransformsUsingFrom*' ```
Observable.from(T) using Observable.just(T)
Update docs for "apply" and add an example
Fixed testConcurrentOnNextFailsValidation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.