Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement didHighlight and didUnhighlight APIs #123

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Implement didHighlight and didUnhighlight APIs #123

merged 3 commits into from
Aug 13, 2024
+151 −7

Conversation

nuomi1
Copy link
Collaborator

@nuomi1 nuomi1 commented Aug 13, 2024

Closes #95

nuomi1 added 2 commits August 13, 2024 12:36
@nuomi1
Implement didHighlight and didUnhighlight APIs

Verified

This commit was signed with the committer’s verified signature. The key has expired.
nuomi1 nuomi1
GPG key ID: E410D5FF602FBF25
Expired
Verified
Learn about vigilant mode
77038f6
@nuomi1
Test didHighlight and didUnhighlight APIs

Verified

This commit was signed with the committer’s verified signature. The key has expired.
nuomi1 nuomi1
GPG key ID: E410D5FF602FBF25
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
686fdeb
@nuomi1
Copy link
Collaborator Author

nuomi1 commented Aug 13, 2024 •
edited
Loading

Another question(PR): More and more expect parameters are being added to fakeCollectionViewModel(), should we roll them up into ExpectConfig?

jessesquires
jessesquires previously approved these changes Aug 13, 2024
View reviewed changes
Copy link
Owner

@jessesquires jessesquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 💯 🥳

Thanks @nuomi1 !

@jessesquires
update changelog

Verified

This commit was signed with the committer’s verified signature.
jessesquires Jesse Squires
GPG key ID: 153766AC1FA1A758
Verified
Learn about vigilant mode
Loading
Loading status checks…
c4879ac
@jessesquires jessesquires merged commit 46e19c5 into main Aug 13, 2024
4 checks passed
@jessesquires jessesquires deleted the feature/highlight branch August 13, 2024 17:56
@jessesquires
Copy link
Owner

Another question(PR): More and more expect parameters are being added to fakeCollectionViewModel(), should we roll them up into ExpectConfig?

Yes, that's a great idea. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesquires jessesquires

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Delegate] implement additional highlight APIs
2 participants
@nuomi1 @jessesquires