Fixes #9 #10
Merged
Fixes #9 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeroendesloovere
requested changes
Mar 14, 2018
Owner
jeroendesloovere
left a comment
jeroendesloovere
left a comment
There was a problem hiding this comment.
Hi @janverton,
Thanks for your PR.
src/Geolocation.php
Outdated
| $response = json_decode($response); | ||
|
|
||
| // API returns with an error | ||
| if (isset($response->error_message)) throw new GeolocationException($response->error_message); |
Owner
There was a problem hiding this comment.
Can you change it to:
if (isset($response->error_message)) {
throw new GeolocationException($response->error_message);
}
Contributor
Author
There was a problem hiding this comment.
Sure will do, although it breaks convention regarding the rest of the class :)
Owner
|
Hi @janverton, I just released 1.4.1. |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws an exception with the
error_messagereturned by the API as message instead of returning an empty lat/long