add an asyncronous test for throttle #1524
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition to the main test.js guarantees that only unique calls are made.
|
It closes #716. However in order to make it work properly index.html file on Plunker should be edited as well: <!doctype html>
<script src="https://en.js.cx/test/libs.js"></script>
<script src="test.js"></script>
<script>
// ...Your code...
</script>
</html>Its required state should be the following: <!doctype html>
<script src="https://en.js.cx/test/libs.js"></script>
<script>
// ...Your code...
</script>
<script src="test.js"></script>
</html> |
|
@dagolinuxoid why should we edit index.html? For other tests it's fine, what's so special about the new test? |
|
Otherwise it's not going to work, that's most likely due to I used the |
|
Thank you! |
|
You changed my test slightly putting all the code inside of anonymous function and now all things are working properly. Good job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition to the main test.js guarantees that only unique calls are made.