Skip to content

Conversation

dagolinuxoid
Copy link
Contributor

The addition to the main test.js guarantees that only unique calls are made.

The addition to the main test.js guarantees that only unique calls are made.
@dagolinuxoid
Copy link
Contributor Author

dagolinuxoid commented Oct 28, 2019

It closes #716. However in order to make it work properly index.html file on Plunker should be edited as well:
Its current state is :

<!doctype html>
<script src="https://en.js.cx/test/libs.js"></script>
<script src="test.js"></script>
<script>

  // ...Your code...

</script>

</html>

Its required state should be the following:

<!doctype html>
<script src="https://en.js.cx/test/libs.js"></script>
<script>

  // ...Your code...

</script>
<script src="test.js"></script>
</html>

@iliakan
Copy link
Member

iliakan commented Oct 28, 2019

@dagolinuxoid why should we edit index.html?

For other tests it's fine, what's so special about the new test?

@dagolinuxoid
Copy link
Contributor Author

Otherwise it's not going to work, that's most likely due to I used the done parameter for it spec. I understand that even small altering of index.html can be a troublesome so it's up to you to make a decision.

@iliakan iliakan closed this in d5195b5 Oct 29, 2019
@iliakan
Copy link
Member

iliakan commented Oct 29, 2019

Thank you!

@dagolinuxoid
Copy link
Contributor Author

dagolinuxoid commented Oct 29, 2019

You changed my test slightly putting all the code inside of anonymous function and now all things are working properly. Good job.

@dagolinuxoid dagolinuxoid deleted the patch-3 branch November 2, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants