Added tasks 357, 363 #112
Added tasks 357, 363 #112
Conversation
| import java.util.Arrays; | ||
|
|
||
| public class Solution { | ||
| private int[] M; |
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class SolutionTest { | ||
|
|
There was a problem hiding this comment.
the empty line appear when I run 'gradlew.bat clean spotlessJavaApply test ' command
There was a problem hiding this comment.
I think we need to add the empty line to pass the check
There was a problem hiding this comment.
Please remove empty line only before @test then format sources
There was a problem hiding this comment.
the empty line appear when I run 'gradlew.bat clean spotlessJavaApply test ' command
I see other tests without empty line.
| class SolutionTest { | ||
|
|
||
| @Test | ||
| void testCountNumbersWithUniqueDigits() { |
There was a problem hiding this comment.
Please rename method without test
| class SolutionTest { | ||
|
|
||
| @Test | ||
| void testMaxSumSubMatrix() { |
There was a problem hiding this comment.
Please rename method without test
|
Please format sources before commit. |
|
|
|
|
|
I see @test without empty line. |
|
Please remove empty line market yellow color. |
It appear when I run command "gradlew.bat clean spotlessJavaApply test --info". if remove we will not pass the checks |
| @@ -93,28 +94,28 @@ private int maxSumSubArray(int[] a, int k) { | |||
| } | |||
|
|
|||
| public int maxSumSubMatrix(int[][] matrix, int k) { | |||
| int m = matrix.length; | |||
| int n = m == 0 ? 0 : matrix[0].length; | |||
| int x = matrix.length; | |||
There was a problem hiding this comment.
Better name variables localM and localN
|
Please remove this line. |
|
Ok, let's leave it. |
|
Kudos, SonarCloud Quality Gate passed! |
|
LGTM |
No description provided.