added tasks 350, 352, 354 #111

ThanhNIT · 2021-12-13T01:00:40Z

No description provided.

javadev · 2021-12-13T01:06:53Z

src/main/java/g0301_0400/s0352_data_stream_as_disjoint_intervals/readme.md

+
+**Output:** \[null, null, \[\[1, 1\]\], null, \[\[1, 1\], \[3, 3\]\], null, \[\[1, 1\], \[3, 3\], \[7, 7\]\], null, \[\[1, 3\], \[7, 7\]\], null, \[\[1, 3\], \[6, 7\]\]\]
+
+**Explanation:** SummaryRanges summaryRanges = new SummaryRanges(); summaryRanges.addNum(1); // arr = \[1\] summaryRanges.getIntervals(); // return \[\[1, 1\]\] summaryRanges.addNum(3); // arr = \[1, 3\] summaryRanges.getIntervals(); // return \[\[1, 1\], \[3, 3\]\] summaryRanges.addNum(7); // arr = \[1, 3, 7\] summaryRanges.getIntervals(); // return \[\[1, 1\], \[3, 3\], \[7, 7\]\] summaryRanges.addNum(2); // arr = \[1, 2, 3, 7\] summaryRanges.getIntervals(); // return \[\[1, 3\], \[7, 7\]\] summaryRanges.addNum(6); // arr = \[1, 2, 3, 6, 7\] summaryRanges.getIntervals(); // return \[\[1, 3\], \[6, 7\]\]


Please change structure to the blocks.

javadev · 2021-12-13T01:07:10Z

src/main/java/g0301_0400/s0352_data_stream_as_disjoint_intervals/SummaryRanges.java

+
+// #Hard #Binary_Search #Design #Ordered_Set
+
+import java.util.*;


It may be concrete classes.

javadev · 2021-12-13T01:08:24Z

src/test/java/g0301_0400/s0352_data_stream_as_disjoint_intervals/SolutionTest.java

+
+import org.junit.jupiter.api.Test;
+
+class SolutionTest {


It may be SummaryRangesTest class name

javadev · 2021-12-13T01:08:55Z

src/test/java/g0301_0400/s0352_data_stream_as_disjoint_intervals/SolutionTest.java

+        summaryRanges.addNum(2);
+        summaryRanges.addNum(3);
+        summaryRanges.addNum(7);
+


Please remove empty line.

javadev · 2021-12-13T01:09:31Z

src/main/java/g0301_0400/s0354_russian_doll_envelopes/Solution.java

+                size++;
+            }
+        }
+


Please remove empty lines.

javadev · 2021-12-13T01:10:06Z

src/main/java/g0301_0400/s0350_intersection_of_two_arrays_ii/Solution.java

+        int i = 0;
+        int j = 0;
+        int k = 0;
+


Please remove empty lines.

javadev · 2021-12-13T01:15:00Z

src/main/java/g0301_0400/s0352_data_stream_as_disjoint_intervals/SummaryRanges.java

+
+public class SummaryRanges {
+
+    private final NavigableSet<int[]> intervals;


This solution is not very fast

I found better implemetation

public class SummaryRanges { private static class Node { int min; int max; public Node(int min, int max) { this.min = min; this.max = max; } public Node(int val) { min = val; max = val; } } List<Node> list; /** Initialize your data structure here. */ public SummaryRanges() { list = new ArrayList<>(); } public void addNum(int val) { int left = 0; int right = list.size()-1; int index = list.size(); while (left <= right) { int mid = left + (right - left) / 2; Node node = list.get(mid); if (node.min <= val && val <= node.max) { return; } else if (val < node.min) { index = mid; right = mid - 1; } else if (val > node.max) { left = mid + 1; } } list.add(index, new Node(val)); } public int[][] getIntervals() { for (int i = 1; i < list.size(); i++) { Node prev = list.get(i-1); Node curr = list.get(i); if (curr.min == prev.max+1) { prev.max = curr.max; list.remove(i--); } } int len = list.size(); int[][] res = new int[len][2]; for (int i = 0; i < len; i++) { Node node = list.get(i); res[i][0] = node.min; res[i][1] = node.max; } return res; } }

javadev · 2021-12-13T01:22:35Z

src/main/java/g0301_0400/s0352_data_stream_as_disjoint_intervals/readme.md

+summaryRanges.getIntervals(); // return \[\[1, 3\], \[7, 7\]\] 
+summaryRanges.addNum(6); // arr = \[1, 2, 3, 6, 7\] 
+summaryRanges.getIntervals(); // return \[\[1, 3\], \[6, 7\]\]
+```


Please remove escapes and replace code block with 4 spaces ident.

We may use four space ident for code blocks.

javadev · 2021-12-13T01:32:12Z

src/main/java/g0301_0400/s0352_data_stream_as_disjoint_intervals/readme.md

+
+**Example 1:**
+
+**Input** \["SummaryRanges", "addNum", "getIntervals", "addNum", "getIntervals", "addNum", "getIntervals", "addNum", "getIntervals", "addNum", "getIntervals"\] \[\[\], \[1\], \[\], \[3\], \[\], \[7\], \[\], \[2\], \[\], \[6\], \[\]\]


It looks like two lines. It may be changes with code block.

javadev · 2021-12-13T01:32:50Z

src/test/java/g0301_0400/s0354_russian_doll_envelopes/SolutionTest.java

+import org.junit.jupiter.api.Test;
+
+class SolutionTest {
+


Please remove empty line.

javadev · 2021-12-13T01:33:44Z

src/main/java/g0301_0400/s0354_russian_doll_envelopes/Solution.java

+
+            while (i != j) {
+                int mid = i + ((j - i) >> 1);
+


Please remove empty lines

I usually code spaces like that to be easier to see than just writing a block

The idea to use plugin to format codes. If it allows to remove empty line - remove it.

javadev · 2021-12-13T01:40:42Z

src/main/java/g0301_0400/s0350_intersection_of_two_arrays_ii/Solution.java

+            }
+        }
+        return Arrays.copyOfRange(nums1, 0, k);
+    }


You may keep comments in solutions.

Trailing comment may be moved to separate line.

like that ?

Yes, we may keep comments. We only need to move them, in separate line above.

javadev · 2021-12-13T01:55:36Z

src/main/java/g0301_0400/s0350_intersection_of_two_arrays_ii/Solution.java

@@ -20,7 +20,8 @@
        while (i < nums1.length && j < nums2.length) {
            // Check if nums1 value is less then nums2 value;
            if (nums1[i] < nums2[j]) {
-                i++; // Increment "i"
+                // Increment "i"
+                i++;
            }
            // Check if nums2 value is less then nums1 value;
            else if (nums1[i] > nums2[j]) {


You may move comment inside if or remove it. The description looks very simple.

sonarqubecloud · 2021-12-13T02:02:31Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

88.6% Coverage
0.0% Duplication

javadev · 2021-12-13T02:03:23Z

LGTM

ThanhNIT added 2 commits December 13, 2021 07:59

added tasks 350, 352, 354

ee39ec4

Update Solution.java

95c9381