This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix: config get #825
Merged
fix: config get #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
Author
|
@diasdavid @alanshaw what do you think? 😄 |
Contributor
Author
daviddias
suggested changes
Aug 6, 2018
Contributor
daviddias
left a comment
daviddias
left a comment
There was a problem hiding this comment.
Needs tests to make sure this doesn't break again.
Contributor
Author
alanshaw
approved these changes
Aug 6, 2018
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
Contributor
Author
|
@alanshaw @diasdavid it's failing on unrelated endpoints (such as |
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes config.get by always returning an object and never a buffer. It can be a possible breaking change for those using js-ipfs-api with go-ipfs, but not with js-ipfs.
Fixes #822.