-
-
Notifications
You must be signed in to change notification settings - Fork 133
New Argument Parsing #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Argument Parsing #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes minor changes focused on dependency updates, formatting improvements, and enhanced type checking in the configurable utilities.
- Introduces overload definitions for the parameter() function to improve type checking.
- Updates init.py to export the newly added parameter function.
- Adds additional dependencies in pyproject.toml.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/hackingBuddyGPT/utils/configurable.py | Updates to parameter() overloads and minor formatting adjustments. |
| src/hackingBuddyGPT/utils/init.py | Exports the new parameter function. |
| pyproject.toml | Adds new dependencies for langchain integrations and markdown. |
|
Looks good, but could you add a bit of.. documentation for the configuration system (: |
|
So I've integrated the working parts of the configuration for now, I only need to finish off the |
9425b76 to
952467d
Compare
(help is not quite optimal, but whatever)
e6a8d04 to
e92faaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces updates to the argument parsing and logging initialization across the project. Key changes include replacing Logger with LocalLogger in various modules, updating function signatures (notably in UseCase initializers and run methods), and marking API key parameters as secret.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/*.py | Update logging initialization and init() invocations |
| src/hackingBuddyGPT/utils/openai/openai_llm.py & openai_lib.py | Mark API key parameter as secret |
| src/hackingBuddyGPT/utils/logging.py | Rename Logger to LocalLogger and add GlobalLocalLogger/RemoteLogger patterns |
| src/hackingBuddyGPT/usecases/base.py | Modify init and run signature to align with new argument parsing |
| src/hackingBuddyGPT/cli/wintermute.py | Refactor command parsing to use the new instantiate function |
| README.md | Update usage instructions and command help output |
Comments suppressed due to low confidence (2)
src/hackingBuddyGPT/usecases/base.py:25
- The init method signature has been changed from accepting a configuration argument to a parameterless method. Please ensure that all use case implementations and dependent code are updated to initialize and propagate configuration via the run() method.
def init(self):
src/hackingBuddyGPT/usecases/viewer.py:235
- The run method now requires a configuration argument whereas previous implementations did not. Please verify that this change is consistently applied across all use cases and that the configuration is properly passed from the CLI to the use case instances.
def run(self, config):
No description provided.