Skip to content

Add time crate support for Timestamp #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 22, 2025
Merged

Conversation

pbzweihander
Copy link
Contributor

Description

{ describe your changes here }

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy
    • with reqwest feature: cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features serde,derive,reqwest-client-rustls -- -D warnings
    • with surf feature: cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features serde,derive,hyper-client -- -D warnings
  • Updated README.md using cargo doc2readme -p influxdb --expand-macros
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

@msrd0
Copy link
Collaborator

msrd0 commented Mar 29, 2024

Thanks, adding time support is something I wanted to see for a long time but never got around to it!

I haven't actually checked where exactly we use chrono, but if it's only for the Timestamp, do you think you could make both chrono and time optional? I feel like most users wouldn't need both at the same time

@pbzweihander
Copy link
Contributor Author

@msrd0 I've updated the PR!

msrd0
msrd0 previously approved these changes Mar 29, 2024
Copy link
Collaborator

@msrd0 msrd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Empty2k12
Copy link
Collaborator

The tests need to be adapted to test both chrono and time independently. The tests should enable the features. Ci is currently failing since chrono could not be found in the test.

@msrd0
Copy link
Collaborator

msrd0 commented Apr 2, 2024

The tests need to be adapted to test both chrono and time independently.

I'm not sure that's necessary. These two features don't seem to conflict each other.

@Empty2k12 Empty2k12 force-pushed the main branch 12 times, most recently from c241371 to 359fd08 Compare December 13, 2024 17:35
@Empty2k12
Copy link
Collaborator

Sorry this took so long. Thanks again for your contribution! I will leave this for @msrd0 to merge. I think the MSRV bump to 1.67.1 due to time-core v0.1.4 is fine.

@Empty2k12 Empty2k12 requested a review from msrd0 August 21, 2025 23:39
msrd0 added 3 commits August 22, 2025 10:09
This was not a thing at the time this PR was opened, but
was added in time 0.3.38
@msrd0 msrd0 enabled auto-merge (squash) August 22, 2025 08:17
@msrd0 msrd0 merged commit 9174a4f into influxdb-rs:main Aug 22, 2025
18 checks passed
@msrd0 msrd0 mentioned this pull request Aug 22, 2025
@pbzweihander pbzweihander deleted the time branch August 22, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants