-
Notifications
You must be signed in to change notification settings - Fork 82
Add time crate support for Timestamp #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, adding I haven't actually checked where exactly we use |
@msrd0 I've updated the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
The tests need to be adapted to test both chrono and time independently. The tests should enable the features. Ci is currently failing since chrono could not be found in the test. |
I'm not sure that's necessary. These two features don't seem to conflict each other. |
c241371
to
359fd08
Compare
Sorry this took so long. Thanks again for your contribution! I will leave this for @msrd0 to merge. I think the MSRV bump to 1.67.1 due to time-core v0.1.4 is fine. |
This was not a thing at the time this PR was opened, but was added in time 0.3.38
Description
{ describe your changes here }
Checklist
cargo fmt --all
cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features serde,derive,reqwest-client-rustls -- -D warnings
cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features serde,derive,hyper-client -- -D warnings
cargo doc2readme -p influxdb --expand-macros