Skip to content

fix: Future truncated shards return duplicate results #26718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master-1.x
Choose a base branch
from
Draft

fix: Future truncated shards return duplicate results #26718

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec8a06e
fix: Future truncated shards return duplicate results
devanbenz Aug 21, 2025
f94f12a
feat: adjust testing
devanbenz Aug 21, 2025
8261e31
fix: Testing some changes locally, pushing them up to save them
devanbenz Aug 22, 2025
803fb1e
chore: Adjust comment
devanbenz Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Testing some changes locally, pushing them up to save them
  • Loading branch information
@devanbenz
devanbenz committed Aug 22, 2025
commit 8261e31a3b7d5ff4733fba9ba2bc6a9da611826c
14 changes: 6 additions & 8 deletions services/meta/data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,20 +1440,18 @@ func (a ShardGroupInfos) Less(i, j int) bool {

// Contains returns true iif StartTime ≤ t < EndTime (or TruncatedAt if truncated).
func (sgi *ShardGroupInfo) Contains(t time.Time) bool {
effectiveEnd := sgi.EndTime
if sgi.Truncated() {
effectiveEnd = sgi.TruncatedAt
if sgi.Truncated() && sgi.TruncatedAt.Equal(sgi.StartTime) {
return false
}
return !t.Before(sgi.StartTime) && t.Before(effectiveEnd)
return !t.Before(sgi.StartTime) && t.Before(sgi.EndTime)
}

// Overlaps returns whether the shard group contains data for the time range between min and max
func (sgi *ShardGroupInfo) Overlaps(min, max time.Time) bool {
effectiveEnd := sgi.EndTime
if sgi.Truncated() {
effectiveEnd = sgi.TruncatedAt
if sgi.Truncated() && sgi.TruncatedAt.Equal(sgi.StartTime) {
return false
}
return !sgi.StartTime.After(max) && effectiveEnd.After(min)
return !sgi.StartTime.After(max) && sgi.EndTime.After(min)
}

// Deleted returns whether this ShardGroup has been deleted.
Expand Down
Loading