Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: from eslint-plugin-i to eslint-plugin-import-x #350

Merged
merged 1 commit into from
Feb 17, 2025
Merged

docs: from eslint-plugin-i to eslint-plugin-import-x #350

merged 1 commit into from
Feb 17, 2025

Conversation

carlocorradini
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025

⚠️ No Changeset found

Latest commit: e425bc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@SukkaW SukkaW added this pull request to the merge queue Feb 17, 2025
Merged via the queue into import-js:master with commit e9bceed Feb 17, 2025
9 checks passed
@carlocorradini carlocorradini mentioned this pull request Feb 17, 2025
Closed
Samuel-Therrien-Beslogic
Samuel-Therrien-Beslogic reviewed Feb 17, 2025
View reviewed changes
README.md
@@ -58,7 +58,7 @@ pnpm i -D eslint-plugin-import eslint-import-resolver-typescript
yarn add -D eslint-plugin-import eslint-import-resolver-typescript
```

**Important when using `eslint-plugin-i` and `npm`**: Use `npm i -D eslint-plugin-import@eslint-plugin-i@latest eslint-import-resolver-typescript`, or you will end up with both `eslint-plugin-import` and `eslint-plugin-i` in your node_modules.
**Important when using `eslint-plugin-import-x` and `npm`**: Use `npm i -D eslint-plugin-import@eslint-plugin-import-x@latest eslint-import-resolver-typescript`, or you will end up with both `eslint-plugin-import` and `eslint-plugin-import-x` in your node_modules.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-plugin-import@eslint-plugin-import-x@latest doesn't exist:

> npm i -D eslint-plugin-import@eslint-plugin-import-x@latest
npm error code EINVALIDTAGNAME
npm error Invalid tag name "eslint-plugin-import-x@latest" of package "eslint-plugin-import@eslint-plugin-import-x@latest": Tags may not have any characters that encodeURIComponent encodes.
npm error A complete log of this run can be found in: C:\Users\SamuelTherrien\AppData\Local\npm-cache\_logs\2025-02-17T20_31_16_264Z-debug-0.log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only replaced the old name with the new name, no more no less.
Would you want to create a PR and fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic left review comments

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlocorradini @SukkaW @Samuel-Therrien-Beslogic