Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is-glob dependency #331

Closed
benmccann opened this issue Dec 15, 2024 · 4 comments · Fixed by #332
Closed

Remove is-glob dependency #331

benmccann opened this issue Dec 15, 2024 · 4 comments · Fixed by #332

Comments

@benmccann
Copy link
Contributor

It was just pointed out to me that it can be replaced with isDynamicPattern from tinyglobby. I'd send a PR, but wasn't eager to fight with yarn

@SukkaW
Copy link
Collaborator

SukkaW commented Dec 16, 2024

I'd send a PR, but wasn't eager to fight with yarn

Do you have corepack enabled? corepack should automatically install, set up, and choose the repo's specified yarn version (yarn@4.0.2 for the time being) for you.

@benmccann
Copy link
Contributor Author

No, I don't have corepack installed

@SukkaW
Copy link
Collaborator

SukkaW commented Dec 16, 2024

Do note that eslint-import-resolver-typescript uses yarn@4.0.2, so the yarn@latest from npm (which will be yarn@1) wouldn't work here.

I'd still prefer you create the PR, I myself would prefer not to "steal" your credits on this~

@benmccann
Copy link
Contributor Author

Ah, I see. That was probably the issue then. It looks like I have yarn 1 installed.

I really don't mind you stealing credit at all. I'm not sure I really want to install corepack for such a small change to be honest. If it helps I could create the PR except for the lockfile change again, but I don't know if that saves you any effort or not

SukkaW added a commit to SukkaW/eslint-import-resolver-typescript that referenced this issue Dec 16, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants