Moved RemoteCanvasActivity functionality for Opaque over to RemoteCan… #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iiordanov
reviewed
Nov 4, 2020
Comment on lines
804
to
809
| /** | ||
| * Reinitialize Opaque | ||
| */ | ||
|
|
||
|
|
||
|
|
iiordanov
reviewed
Nov 4, 2020
| @@ -245,10 +248,12 @@ public void run() { | |||
| pd.setCanceledOnTouchOutside(false); | |||
| } | |||
|
|
|||
| RemotePointer init(final Connection settings, final Handler handler, final Runnable setModes) { | |||
| void init(final Connection settings, final Handler handler, final Runnable setModes, final Runnable clearToggles, final String vvFileName) { | |||
There was a problem hiding this comment.
We don't want to handle reauth for vvFile because it simply means the vv file expired.
iiordanov
reviewed
Nov 4, 2020
| @@ -279,19 +279,26 @@ public void run() { | |||
| } catch (NullPointerException e) { | |||
| } | |||
| }}; | |||
| Runnable clearToggles = new Runnable() { | |||
There was a problem hiding this comment.
Please rename clearToggles runnable and function to something more descriptive to its function.
iiordanov
reviewed
Nov 4, 2020
| @@ -33,6 +33,7 @@ | |||
| <string name="connection_setup_user">User@Domain</string> | |||
| <string name="connection_setup_password">Password (saved if entered)</string> | |||
| <string name="enter_password">Please enter password</string> | |||
| <string name="enter_password_auth_failed">Authentication failed. Please re-enter your credentials.</string> | |||
There was a problem hiding this comment.
Please pull in latest from master get Spanish translations in, and then add the new english strings as-is to all languages.
…vas. Added retry to PVE and Ovirt if credentials are incorrect.
nkotixwolf
force-pushed
the
feature/save-pwd-opaque-2
branch
from
8715c73 to
0f29cfd
Compare
iiordanov
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added password retry for Ovirt and PVE