Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling latest changes #1

Merged
merged 28 commits into from
Oct 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
dbfe9f1
return list instead of console.log
maharshi-gor Oct 8, 2019
7cfb06f
Adds testing for the get mazePath problem #48
glennforrest Oct 8, 2019
d153c6c
Add unit tests to postfix expression evaluation function. Resolves #34
Oct 9, 2019
9e07a94
Merge pull request #52 from Mk996/master
ashokdey Oct 9, 2019
5c826c5
Merge pull request #59 from vobango/master
TheSTL Oct 10, 2019
19222fb
Merge pull request #53 from glennforrest/adds-tests-for-get-mazePath
TheSTL Oct 10, 2019
05184c4
update: find k-th max in BST
ashokdey Oct 10, 2019
4a75147
update: entry in readme
ashokdey Oct 10, 2019
93af26e
Merge branch 'master' of github.com:knaxus/problem-solving-javascript…
ashokdey Oct 10, 2019
f376135
fix: closing of `<sup>`
ashokdey Oct 10, 2019
0ff8d47
fix: typo error
ashokdey Oct 10, 2019
0bf9860
update: find kth min & throw error for invalid K
ashokdey Oct 10, 2019
4980e96
Merge branch 'problems' of github.com:knaxus/problem-solving-javascri…
ashokdey Oct 10, 2019
ca93db3
update: entry in README & folder rename
ashokdey Oct 10, 2019
b4507f1
update: rename folder and fix condition for K
ashokdey Oct 10, 2019
ab8b038
update: fix entries in readme
ashokdey Oct 10, 2019
81c88b8
update: find all ancestors of a node
ashokdey Oct 10, 2019
252e912
update: entry in README
ashokdey Oct 10, 2019
c9e3a6a
update: reverse order of pushing nodes
ashokdey Oct 10, 2019
c4a733a
update: height of BST
ashokdey Oct 10, 2019
c95821c
update: entry in README
ashokdey Oct 10, 2019
a75e950
update: Find k nodes from the root
ashokdey Oct 10, 2019
6416cfc
update: entry in README
ashokdey Oct 10, 2019
bfbee74
Merge pull request #62 from knaxus/problems
TheSTL Oct 10, 2019
597cd0e
Fix Fibonacci problem for negative numbers (#55)
SumeetHaryani Oct 10, 2019
97f8f94
fix: change in code, return null when node not found
ashokdey Oct 11, 2019
28e73b5
update: fix the edge case using array approach
ashokdey Oct 11, 2019
e78eae5
Merge pull request #63 from knaxus/trees
ashokdey Oct 11, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,20 @@ Collection of interview questions with Unit Tests. Problems includes Data Struct
- [Remove Consecutive Repeated Digits](src/_DataStructures_/Stack/remove-consecutive-repeated-digits)
- [Implement 2 Stacks using Single Array](src/_DataStructures_/Stack/2-stacks-using1-array)


- [Queue](src/_DataStructures_/Queue)

- [Weave](src/_DataStructures_/Queue/weave)

- [Doubly Linked List](src/_DataStructures_/DoublyLinkedList)

- [Trees](src/_DataStructures_/Trees)
- [Binary Search Tree](src/_DataStructures_/Trees/BST)
- [Binary Search Tree](src/_DataStructures_/Trees/BinarySearchTree)
- [Find k<sup>th</sup> maximum in a BinarySearchTree](src/_DataStructures_/Trees/BinarySearchTree/find-kth-max)
- [Find k<sup>th</sup> minimum in a BinarySearchTree](src/_DataStructures_/Trees/BinarySearchTree/find-kth-min)
- [Find Ancestors of a Node](src/_DataStructures_/Trees/BinarySearchTree/find-ancestors)
- [Find Height of BST](src/_DataStructures_/Trees/BinarySearchTree/height-of-bst)
- [Find k Nodes from Root of BST](src/_DataStructures_/Trees/BinarySearchTree/find-k-nodes-from-root)
- [Suffix Tree](src/_DataStructures_/SuffixTree)

### Logical Problems
Expand All @@ -50,7 +56,7 @@ Collection of interview questions with Unit Tests. Problems includes Data Struct
- [FizzBuzz](src/_Problems_/fizzbuzz)
- [String Permutaions](src/_Problems_/get-string-permutations)
- [Get Subsequence](src/_Problems_/get_subsequence)
- [Get Maze Path](src/_Problems_/get_subsequence)
- [Get Maze Path](src/_Problems_/get-mazePath)
- [Get longest consecutive 1s](src/_Problems_/max-consecutive-1s)
- [Get Max Char](src/_Problems_/maxchar)
- [Get Smallest Common Number](src/_Problems_/get-smallest-common-number)
Expand Down
13 changes: 10 additions & 3 deletions src/_Classics_/fibonacci/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@
// the algorithm has time complexity of O(n^2), very bad!
function fibonacci(position) {
// if position is 1 or 2, the number in fibonacci sequence will be 1
if (position <= 1) {
if (position === 1 || position === 0) {
return position;
} else if (position < 0) {
throw new Error('Invalid Position');
}

// else the element in fibonacci sequence will be the sum of
Expand All @@ -26,8 +28,11 @@ function fibonacciMemoized(index, cache) {
if (cache[index]) {
return cache[index];
} else {
if (index <=1) {
if (index === 1 || index === 0) {
return index;
} else if (index < 0) {
throw new Error('Invalid Position');

} else {
cache[index] =
fibonacciMemoized(index - 1, cache) +
Expand All @@ -43,8 +48,10 @@ function fibonacciMemoized(index, cache) {

function fibonacciTabular(n) {
const table = [0, 1];
if (n <= 1) {
if (n === 1 || n === 0) {
return n;
} else if (n < 0) {
throw new Error('Invalid Position');
}
for (let i = 2; i <= n; i += 1) {
table[i] = table[i - 1] + table[i - 2];
Expand Down
4 changes: 3 additions & 1 deletion src/_DataStructures_/DoublyLinkedList/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,12 @@ class DoublyLinkedList {

display() {
let address = this.head.next;
let addresses = []
while (address !== this.tail) {
console.log(address.data);
addresses.push(address.data)
address = address.next;
}
return addresses
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/_DataStructures_/Queue/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ class Queue {
}
}

module.exports = Queue;
module.exports = Queue;
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ function evaluatePostfixExpression(expression) {
s.push(Number(char));
} else {
// if char is an operator then pop two elements from stack, evaluate them accordingly based on operator.
//push the result to stack
//push the result to stack
let val1 = s.pop();
let val2 = s.pop()
let val2 = s.pop();
switch (char) {
case '+':
s.push(val2 + val1);
Expand All @@ -38,3 +38,7 @@ function evaluatePostfixExpression(expression) {
//pop the value of postfix expression
return s.pop();
}

module.exports = {
evaluatePostfixExpression,
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
const { evaluatePostfixExpression } = require('.');

describe('Postfix expression evaluation', function () {
it('should be a function', function () {
expect(typeof evaluatePostfixExpression).toEqual('function');
});

it('should return a number', function () {
const expression = '11+';

expect(typeof evaluatePostfixExpression(expression)).toEqual('number')
});

it('should handle addition', function () {
const expression = '23+';
const expected = 5;

expect(evaluatePostfixExpression(expression)).toEqual(expected);
});

it('should handle subtraction', function () {
const expression = '54-';
const expected = 1;

expect(evaluatePostfixExpression(expression)).toEqual(expected);
});

it('should handle multiplication', function () {
const expression = '34*';
const expected = 12;

expect(evaluatePostfixExpression(expression)).toEqual(expected);
});

it('should handle division', function () {
const expression = '62/';
const expected = 3;

expect(evaluatePostfixExpression(expression)).toEqual(expected);
});

it('should handle negative numbers', function () {
const expression = '25-';
const expected = -3;

expect(evaluatePostfixExpression(expression)).toEqual(expected);
});

it('should handle multiple operators', function () {
const expression = '123*+';
const expected = 7;

expect(evaluatePostfixExpression(expression)).toEqual(expected);
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
// eslint-disable-next-line no-unused-vars
const BST = require('../index');

/** You should go through this conversation here:
* https://github.com/knaxus/problem-solving-javascript/pull/63
*/

function findAncestors(root, value) {
/**
* search the given node and meanwhile
* keep pushing the visited nodes
*/
if (root === null) return false;

if (value < root.value) {
const left = findAncestors(root.leftChild, value);
if (left) {
return [...left, root.value];
}
return false;
}

if (value > root.value) {
const right = findAncestors(root.rightChild, value);
if (right) {
return [...right, root.value];
}
return false;
}

if (value === root.value) return [];
return false;
}

// create a BST
// const myBST = new BST(6);
// myBST.add(4);
// myBST.add(9);
// myBST.add(2);
// myBST.add(5);
// myBST.add(14);
// myBST.add(8);
// myBST.add(12);
// myBST.add(10);

// console.log(findAncestors(myBST.root, 10));
// console.log(findAncestors(myBST.root, 101));

module.exports = findAncestors;
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// eslint-disable-next-line no-unused-vars
const BST = require('../index');

function findKNodes(root, k) {
let arr = [];

if (root === null) return [];
if (k === 0) return [...arr, root.value];

const left = findKNodes(root.leftChild, k - 1);
arr = [...arr, ...left];

const right = findKNodes(root.rightChild, k - 1);
arr = [...arr, ...right];
return arr;
}

// create a BST
// const myBST = new BST(6);

// myBST.add(2);
// myBST.add(19);
// myBST.add(14);
// myBST.add(8);
// myBST.add(5);
// myBST.add(12);
// myBST.add(33);
// myBST.add(52);
// myBST.add(1);

// console.log(findKNodes(myBST.root, 2));

module.exports = findKNodes;
39 changes: 39 additions & 0 deletions src/_DataStructures_/Trees/BinarySearchTree/find-kth-max/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// eslint-disable-next-line no-unused-vars
const BST = require('../index');

// Inorder traversal returns a sorted array
function inOrderTraversal(root) {
if (root === null) return [];
let arr = [];
// traverse left
const left = inOrderTraversal(root.leftChild);
arr = [...left, root.value];
const right = inOrderTraversal(root.rightChild);
return [...arr, ...right];
}

function findKthMax(rootNode, k) {
const arr = inOrderTraversal(rootNode);
if (k <= 0 || k > arr.lenth) {
throw new Error('Invalid value for K');
}
return arr[arr.length - k];
}

// // create a BST
// const myBST = new BST(6);

// myBST.add(2);
// myBST.add(19);
// myBST.add(14);
// myBST.add(8);
// myBST.add(5);
// myBST.add(12);
// myBST.add(33);
// myBST.add(52);
// myBST.add(1);

// // find 3rd max
// console.log(findKthMax(myBST.root, 3));

module.exports = findKthMax;
39 changes: 39 additions & 0 deletions src/_DataStructures_/Trees/BinarySearchTree/find-kth-min/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// eslint-disable-next-line no-unused-vars
const BST = require('../index');

// Inorder traversal returns a sorted array
function inOrderTraversal(root) {
if (root === null) return [];
let arr = [];
// traverse left
const left = inOrderTraversal(root.leftChild);
arr = [...left, root.value];
const right = inOrderTraversal(root.rightChild);
return [...arr, ...right];
}

function findKthMin(rootNode, k) {
const arr = inOrderTraversal(rootNode);
if (k <= 0 || k > arr.lenth) {
throw new Error('Invalid value for K');
}
return arr[k - 1];
}

// // create a BST
// const myBST = new BST(6);

// myBST.add(2);
// myBST.add(19);
// myBST.add(14);
// myBST.add(8);
// myBST.add(5);
// myBST.add(12);
// myBST.add(33);
// myBST.add(52);
// myBST.add(1);
// myBST.add(0);

// console.log(findKthMin(myBST.root, 3));

module.exports = findKthMin;
33 changes: 33 additions & 0 deletions src/_DataStructures_/Trees/BinarySearchTree/height-of-bst/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// eslint-disable-next-line no-unused-vars
const BST = require('../index');

function findHeightOfBST(root) {
let leftHeight = 0;
let rightHeight = 0;

if (root === null) return 0;
leftHeight = findHeightOfBST(root.leftChild);
rightHeight = findHeightOfBST(root.rightChild);

if (leftHeight > rightHeight) {
return leftHeight + 1;
}
return rightHeight + 1;
}

// create a BST
// const myBST = new BST(6);
// myBST.add(4);
// myBST.add(9);
// myBST.add(2);
// myBST.add(5);
// myBST.add(14);
// myBST.add(8);
// myBST.add(12);
// myBST.add(10);

// // console.log(myBST.root);
// console.log(myBST.traversePreorder());
// console.log(findHeightOfBST(myBST.root));

module.exports = findHeightOfBST;
Loading