Add MP Net 2 #9004
Closed
Add MP Net 2 #9004
+4,248
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Julien Plu <plu.julien@gmail.com>
Co-authored-by: Julien Plu <plu.julien@gmail.com>
Co-authored-by: Julien Plu <plu.julien@gmail.com>
Co-authored-by: Julien Plu <plu.julien@gmail.com>
Co-authored-by: Julien Plu <plu.julien@gmail.com>
Co-authored-by: Julien Plu <plu.julien@gmail.com>
5 tasks
|
@patrickvonplaten Never mind, just use this PR is ok. I am ok if our work can be merged into the master quickly. |
|
@jplu @LysandreJik @sgugger , we all gave our thumbs-up in the old PR. It's a bit unfortunate that the authorship is slightly changed here, but the PR should be read to merge. |
jplu
approved these changes
Dec 9, 2020
LysandreJik
pushed a commit
that referenced
this pull request
Dec 9, 2020
|
Squashed commit & cherry picked on the |
|
@StillKeepTry thanks a lot for all of your hard work on this PR! Glad to welcome MPNet in the library! |
|
Thanks every reviewer for helping review our work. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Copy of #8971 that had to close because of problems with git history.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.