s2s: fix LR logging, remove some dead code. #6205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6205 +/- ##
==========================================
+ Coverage 79.65% 79.73% +0.07%
==========================================
Files 146 146
Lines 26607 26607
==========================================
+ Hits 21194 21214 +20
+ Misses 5413 5393 -20
Continue to review full report at Codecov.
|
sgugger
reviewed
Aug 3, 2020
| @@ -159,11 +158,9 @@ def _feature_file(self, mode): | |||
| @pl.utilities.rank_zero_only | |||
| def on_save_checkpoint(self, checkpoint: Dict[str, Any]) -> None: | |||
| save_path = self.output_dir.joinpath("best_tfmr") | |||
| save_path.mkdir(exist_ok=True) | |||
There was a problem hiding this comment.
Is it created somewhere else?
There was a problem hiding this comment.
yeah in save_pretrained
sgugger
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.