Application support path fix

[ghost]

I discovered that post Path.swift fix the location of the default models folder was inconsistent. This PR creates a new internal API to access the user domain applicationSupportDirectory to improve consistency. If there is an issue with the user domain then this code will fall back to URL.applicationSupportDirectory but under normal operating conditions it should use the app bundle.

In the previous code I was using URL.applicationSupportDirectory directly which results in /Users//Library/Application Support/hs-diffusion-models

Whereas the previous and correct usage is
/Users//Library/Application Support/hf-diffusion-models

I've put the new applicationSupportURL function inside Settings. To access it use Settings.shared.applicationSupportURL()

Is Settings.shared a reasonable location for such an API? It's not quite a Util function.

(Note: this is extracted from the last commit to #59 and should commit before and then merge back into 59 before it's reviewed.)

[pcuenca]

How did this issue manifest in practice? Was it using different locations at different times?

It's fine to add this as long as we make sure that:

• It works on iOS and macOS
• It works with/without code signing. The default locations change with code-signing, so maybe that was the reason you were seeing inconsistent paths?

I usually do development on Mac without code signing, but then to distribute the app we need to enable it of course. I think it doesn't matter that the locations don't match, as long as we don't break distribution builds :)

Also, it'd be nice to keep the same download location for distribution builds so people that installed the app from the Mac Store don't need to download the model again.

[ghost]

It was all in macOS Xcode testing, no signing issues. I noticed I didn't properly describe the two locations...
/Users/-user-/Library/Application Support/hf-diffusion-models
vs. the bundle ID...
/Users/-user-/Library/Application Support/com.huggingface.Diffusion/hf-diffusion-models

I'll make a test project and compare mac vs iOS FileManager vs. URL vs. Path.swift.

[ghost]

Sample code:
.onAppear() {
print("URL.applicationSupportDirectory")
print(URL.applicationSupportDirectory)
print("FileManager.default.urls(for: .applicationSupportDirectory, in: .userDomainMask).first")
print(FileManager.default.urls(for: .applicationSupportDirectory, in: .userDomainMask).first!)
print("FileManager.default.temporaryDirectory")
print(FileManager.default.temporaryDirectory)
print("Path.applicationSupport / "hf-diffusion-models"")
print(Path.applicationSupport / "hf-diffusion-models")
print("URL.applicationSupportDirectory.appendingPathComponent("hf-diffusion-models")")
print(URL.applicationSupportDirectory.appendingPathComponent("hf-diffusion-models"))
}

Output:
iOS test:
URL.applicationSupportDirectory
file:///Users/-user-/Library/Developer/CoreSimulator/Devices/55E25E20-B2B5-4093-BB99-1F49921D632F/data/Containers/Data/Application/14AF9A03-2DEC-44F3-AF5E-6EDD6C429892/Library/Application%20Support/

FileManager.default.urls(for: .applicationSupportDirectory, in: .userDomainMask).first
file:///Users/-user-/Library/Developer/CoreSimulator/Devices/55E25E20-B2B5-4093-BB99-1F49921D632F/data/Containers/Data/Application/14AF9A03-2DEC-44F3-AF5E-6EDD6C429892/Library/Application%20Support/

FileManager.default.temporaryDirectory
file:///Users/-user-/Library/Developer/CoreSimulator/Devices/55E25E20-B2B5-4093-BB99-1F49921D632F/data/Containers/Data/Application/14AF9A03-2DEC-44F3-AF5E-6EDD6C429892/tmp/

Path.applicationSupport / "hf-diffusion-models"
/Users/-user-/Library/Developer/CoreSimulator/Devices/55E25E20-B2B5-4093-BB99-1F49921D632F/data/Containers/Data/Application/14AF9A03-2DEC-44F3-AF5E-6EDD6C429892/Library/Application Support/hf-diffusion-models

URL.applicationSupportDirectory.appendingPathComponent("hf-diffusion-models")
file:///Users/-user-/Library/Developer/CoreSimulator/Devices/55E25E20-B2B5-4093-BB99-1F49921D632F/data/Containers/Data/Application/14AF9A03-2DEC-44F3-AF5E-6EDD6C429892/Library/Application%20Support/hf-diffusion-models

macOS test:

URL.applicationSupportDirectory
file:///Users/-user-/Library/Containers/com.huggingface.testMac/Data/Library/Application%20Support/

FileManager.default.urls(for: .applicationSupportDirectory, in: .userDomainMask).first
file:///Users/-user-/Library/Containers/com.huggingface.testMac/Data/Library/Application%20Support/

FileManager.default.temporaryDirectory
file:///var/folders/mt/h675p97j56s_1y2s4955rfxm1122/T/com.huggingface.testMac/

Path.applicationSupport / "hf-diffusion-models"
/Users/-user-/Library/Containers/com.huggingface.testMac/Data/Library/Application Support/hf-diffusion-models

URL.applicationSupportDirectory.appendingPathComponent("hf-diffusion-models")
file:///Users/-user-/Library/Containers/com.huggingface.testMac/Data/Library/Application%20Support/hf-diffusion-models

Result: these are pretty consistent actually.
What I was seeing was instead of /Users/-user-/Library/Containers/com.huggingface.testMac/Data/Library/Application Support/hf-diffusion-models the models folder was being put one folder up at /Users/-user-/Library/Containers/com.huggingface.testMac/Data/Library/hf-diffusion-models

Therefore, to avoid accidental misshapen code I thought it would make sense to have our own internal API to call on the correct folder rather than reconstructing it each time we want to interact. Do you think that this submission, given the comparable results above, is overkill?

[pcuenca]

Result: these are pretty consistent actually. What I was seeing was instead of /Users/-user-/Library/Containers/com.huggingface.testMac/Data/Library/Application Support/hf-diffusion-models the models folder was being put one folder up at /Users/-user-/Library/Containers/com.huggingface.testMac/Data/Library/hf-diffusion-models

Oh, I see. Do you know when was this happening?

[pcuenca]

👍

[ghost]

Removing app bundle folder container.