Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Common group #55

Merged
merged 1 commit into from Jun 23, 2023
Merged

Created Common group #55

merged 1 commit into from Jun 23, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 22, 2023

XCode file order update. Created a new "Common" group at the top level and moved all files that are assigned to both the Diffusion and the Diffusion-macOS targets into the common folder. Extracted from pull 51 - #51

Reasoning:
This project contains two build targets. One is iOS/Mac Catalyst and the other is macOS. There are "common" files that are foundational which are used by both targets. By creating a new top level Common group and moving these files into that location it can be easier to spot which files are unique to which build target while navigating through files.

XCode file order update. Created a new "Common" group at the top level and moved all files that are assigned to both the Diffusion and the Diffusion-macOS targets into the common folder. Extracted from pull 51 - #51
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Initially there was a single target (iOS + mac catalyst), then we decided to create a mac specific one and it got a bit disorganized.

@pcuenca pcuenca merged commit 8a684e9 into huggingface:main Jun 23, 2023
@pcuenca pcuenca mentioned this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant