Skip to content

Conversation

@gsnedders
Copy link
Member

No description provided.

@gsnedders
Copy link
Member Author

This doesn't work because PIP_VERSION is consumed by PIP. Need to rename the env variable.

@willkg willkg added this to the 1.0 milestone Oct 3, 2017
@willkg
Copy link
Contributor

willkg commented Oct 31, 2017

I understand the gist of what this is trying to solve, but I think this is better solved with tox and environment matrixes.

I think we should close this out and reimplement it after the PR switching to tox has landed.

Regardless, I'm taking this out of the 1.0 milestone.

@willkg willkg removed this from the 1.0 milestone Oct 31, 2017
@ambv
Copy link
Member

ambv commented Mar 3, 2023

It would be nice to test the minimum versions of dependencies that we support. Luckily, there really only is six and webencodings that are required. six will go away when Python 2 support is gone.

However, we should NOT be pinning maximum versions as overly restrictive version caps cannot be fixed by the user. See: https://iscinumpy.dev/post/bound-version-constraints/

In any case, this PR is quite outdated. I'll make a new one to declare minimum versions of all dependencies that we still use in master.

@ambv ambv closed this Mar 3, 2023
@ambv ambv mentioned this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants