Skip to content

Warn on missing testdata submodule #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SimonSapin opened this issue Nov 30, 2013 · 0 comments · Fixed by #265
Closed

Warn on missing testdata submodule #122

SimonSapin opened this issue Nov 30, 2013 · 0 comments · Fixed by #265
Labels
enhancement has-active-pull-request

Comments

@SimonSapin
Copy link
Contributor

Steps to reproduce:

git clone https://github.com/html5lib/html5lib-python.git
cd html5lib-python
tox

The tests fail with error messages like:

FileNotFoundError: [Errno 2] No such file or directory: '…/html5lib-python/html5lib/tests/testdata/encoding/chardet/test_big5.txt'

The reason is that git clone does not clone/checkout submodules by default. The fix is to run git submodule update --init.

When finding html5lib/tests/testdata empty, the test harness should print an appropriate warning with instructions.
blag pushed a commit to blag/html5lib-python that referenced this issue May 21, 2014
Fix issue html5lib#122 by adding instructions on how to get html5lib/…
2fe4286 
…tests/testdata/encoding/chardet/test_big5.txt from git
@gsnedders gsnedders mentioned this issue Apr 28, 2015
Closed
5 tasks
gsnedders added a commit to gsnedders/html5lib-python that referenced this issue Jun 7, 2016
@gsnedders
Fix html5lib#122: Check the testdata submodule is present
ce6a40f
gsnedders added a commit to gsnedders/html5lib-python that referenced this issue Jun 8, 2016
@gsnedders
Fix html5lib#122: Check the testdata submodule is present
662f2db
@gsnedders gsnedders mentioned this issue Jun 8, 2016
Merged
gsnedders added a commit to gsnedders/html5lib-python that referenced this issue Jun 27, 2016
@gsnedders
Fix html5lib#122: Check the testdata submodule is present
2b73979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement has-active-pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A bunch of testing fixes gsnedders/html5lib-python
2 participants
@gsnedders @SimonSapin