Fix defect that currentValue parameter is still null in BeforeExecutionGenerator#generate() when id allowed to be assigned and was assigned #9965
Conversation
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
NathanQingyangXu
changed the title
…oreExecutionGenerator#generate() when id allowed to be assigned and was assigned
NathanQingyangXu
force-pushed
the
HHH-19320
branch
from
0c1a080 to
f41d926
Compare
| else if ( generatedBeforeExecution ) { | ||
| else if ( generatedBeforeExecution && ( ! generator.allowAssignedIdentifiers() || persister.getIdentifier( entity, source ) == null ) ) { |
There was a problem hiding this comment.
While I agree with the scope of the change, I don't believe this is the correct way to do it. This way, when allowAssignedIdentifier returns true and there is a non-null value we do not call generate at all.
I would say we want to still invoke your custom BeforeExecutionGenerator though, and pass the existing identifier through the currentValue parameter.
There was a problem hiding this comment.
I would say we want to still invoke your custom
BeforeExecutionGeneratorthough, and pass the existing identifier through thecurrentValueparameter.
Yes, I agree. I think the bug is that currentValue is null when it shouldn't be.
There was a problem hiding this comment.
I think the bug is that currentValue is null when it shouldn't be.
[That's what I was trying to say in the comment I left on the issue, though now I realize my comment wasn't very clear.]
|
I've opened #9969 which tests all cases (including non-id properties) as handles assigned ids via |
Thanks. Now I closed this PR. |
https://hibernate.atlassian.net/browse/HHH-19320
Found this defect when working on Hibernate integration project in MongoDB.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.