HHH-19324 - Switch tests using hbm.xml to use mapping.xml #9956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * Wraps the result of {@linkplain #determineAttributeJavaType} in a {@linkplain ClassTypeDetailsImpl} | ||
| * Handles {@code <id/>}, {@code <basic/>}, {@code <tenant-id/>}. | ||
| */ | ||
| private static TypeDetails determineAttributeJavaTypeDetails( |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| // explicit <target/> | ||
| final String target = jaxbBasicMapping.getTarget(); | ||
| if ( isNotEmpty( target ) ) { | ||
| final SimpleTypeInterpretation simpleTypeInterpretation = SimpleTypeInterpretation.interpret( target ); |
Check notice
Code scanning / CodeQL
Unread local variable Note
| * Handles {@code <any/>}, {@code <many-to-any/>}. | ||
| */ | ||
| private static TypeDetails determineAttributeJavaTypeDetails( | ||
| JaxbAnyMapping jaxbAnyMapping, |
Check notice
Code scanning / CodeQL
Useless parameter Note
HHH-19310 - Simplified declaration of type for basic mappings in XML
sebersole
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHH-19324 - Switch tests using hbm.xml to use mapping.xml
HHH-19310 - Simplified declaration of type for basic mappings in XML
This is preliminary work which is converting tests using hbm.xml mappings to instead use mapping.xml and addressing gaps. Ultimately this PR will get merged into main (7.x).
Once all tests have been converted and gaps addressed (which just might mean Jira created for thre moment), we can start actually removing the code for applying hbm.xml - though that will be 8.x specific
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19324