Conversation
…eve file URL or data URI
hellosign_sdk/hsclient.py
Outdated
| return request.get(self.SIGNATURE_REQUEST_LIST_URL, parameters=parameters) | ||
|
|
||
| def get_signature_request_file(self, signature_request_id, path_or_file=None, file_type=None, filename=None): | ||
| def get_signature_request_file(self, signature_request_id, path_or_file=None, file_type=None, filename=None, get_url=False, get_data_uri=False): |
There was a problem hiding this comment.
Can one actually do both? if not, maybe pass in string constants for response format?
| # def get_template_files(self, template_id): | ||
| def get_template_files(self, template_id, filename): | ||
| ''' Download a PDF copy of a template's original files | ||
| def get_template_files(self, template_id, path_or_file=None, file_type=None, |
There was a problem hiding this comment.
This could potentially use the same response type constants?
michaelnlindsay
left a comment
michaelnlindsay
left a comment
There was a problem hiding this comment.
Wow, lotta work here, Thanks for adding comments and cleaning up 👍
I'm wondering about a collection of properties that seems to have been added throughout. eg.
"allow_decline": self._boolean(allow_decline),
"skip_me_now": self._boolean(skip_me_now),
"allow_decline": self._boolean(allow_decline),
"allow_reassign": self._boolean(allow_reassign),
"signing_options": json.dumps(signing_options)
Should these be encapsulated into a new object like request_options that can be passed around instead of all the individual settings?
I'll approve because my comments are more opinion based, your code changes look clean and like they'll behave as intended.
|
|
||
| return json_response if get_json is True else response | ||
|
|
||
| def delete(self, url, headers=None): |
There was a problem hiding this comment.
this one's just adding a generic delete function to be able to make these kinds of requests since this SDK's only been able to make get and post requests before
There was a problem hiding this comment.
Sounds good, would it be worth adding some guidance in comments about what object types can be deleted?
There was a problem hiding this comment.
good call! i added some detail to the comments
|
@michaelnlindsay I made the changes to the |
|
lgtm! |
4 participants
Added in most parameters and endpoints
Resolves #43, #27, #17