Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

Fix for Issue #33#45

Closed
thisjustin wants to merge 1 commit intohellosign:v3from
thisjustin:patch-1
Closed

Fix for Issue #33#45
thisjustin wants to merge 1 commit intohellosign:v3from
thisjustin:patch-1

Conversation

@thisjustin
Copy link

This is a workaround to handle the fact that _boolean returns integers as strings that are supposed to represent boolean values

This is a workaround to handle the fact that `_boolean` returns integers as strings that are supposed to represent boolean values
@BHSPitMonkey
Copy link
Contributor

Thanks for this contribution! This is a great catch, however it looks to me like the root issue is that we shouldn't be using the _boolean function in these places where we're building a params object to pass as function parameters. (I think it's only supposed to be used when we're creating the payload objects for the actual HTTP request.)

I've gone ahead and made those changes in #46, so I'm going to close this one. Let us know if that works for you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants