Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Increase IOT Data Transfer Cost #698

Merged
merged 17 commits into from
Jun 15, 2023
Merged

Conversation

KeithRettig
Copy link
Contributor

@KeithRettig KeithRettig commented Jun 12, 2023

Create new HIP request. Supersedes #685 and #680

Rendered

@abhay
Copy link
Contributor

abhay commented Jun 12, 2023

Thanks for breaking this apart.

Copy link
Contributor

@abhay abhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments / opportunities for improvements made. None of them required. Let the foundation team know if you'd like to move forward as is.

@abhay abhay changed the title Create 0000-align-iot-subdao-per-packet-cost-with-per-packet-value Align IOT subDAO Per Packet Cost with Per Packet Value Jun 12, 2023
KeithRettig and others added 9 commits June 12, 2023 17:05
Agree

Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Agree

Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Agree

Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Agree

Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Agree

Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Agree

Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Agree

Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
thank you

Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
Co-authored-by: Abhay Kumar <75+abhay@users.noreply.github.com>
@abhay
Copy link
Contributor

abhay commented Jun 13, 2023

@KeithRettig can you add ".md" to the filename?

@KeithRettig
Copy link
Contributor Author

Filename changed.

…et-value.md to 0000-increase-iot-data-transfer-cost.md
@abhay abhay changed the title Align IOT subDAO Per Packet Cost with Per Packet Value Proposal: Increase IOT Data Transfer Cost Jun 13, 2023
@waveform06
Copy link
Collaborator

In Detailed Explanation:
Can you clarify for the readers who "customers" are? Sensor owners or hotspot owners.
Ref "The number of packets a Hotspot must transfer to earn a meaningful amount borders on ridiculous."
(a) What would be a non ridiculous amount to stop using that word?
(b) Nowhere in this HIP does it mention that the hotspot that transfers 24byes will receive double DC rewards. It only talks of cost doubling for the "customer". A non specified assumption has been made that double cost = double reward. Clarification confirmation is needed. (Will reduce PoC rewards is a Drawback)
And IMHO the section on region scaling should be fleshed out as a future requirement or removed as superfluous

@gateholder
Copy link

I think we should also be talking about the "location" services the Hivemapper and others use for real time tracking. the number thrown around was 300% also do we want to consider a schedule for increases in the future?

@KeithRettig
Copy link
Contributor Author

And IMHO the section on region scaling should be fleshed out as a future requirement or removed as superfluous

Can you take this one up with @abhay as that sentence was requested by him. I don't think I can flesh it out much further myself.

@abhay
Copy link
Contributor

abhay commented Jun 13, 2023

And IMHO the section on region scaling should be fleshed out as a future requirement or removed as superfluous

Can you take this one up with @abhay as that sentence was requested by him. I don't think I can flesh it out much further myself.

My thinking here is that this is going be one of the first things that's commented on in the community. I'd like to at least acknowledge that it's something that could be done but not within scope of this HIP.

@abhay
Copy link
Contributor

abhay commented Jun 15, 2023

@KeithRettig thoughts on any more edits or would you like to move forward to discussion? I'm open either way.

You could potentially address @waveform06's and @gateholder's comments or leave them as for open discussion.

@KeithRettig
Copy link
Contributor Author

@KeithRettig thoughts on any more edits or would you like to move forward to discussion? I'm open either way.

You could potentially address @waveform06's and @gateholder's comments or leave them as for open discussion.

I am going to edit some more late tonight in response to those comments. Haven't decided exactly how I want to respond to them yet. Off to a pre-release movie showing.

@KeithRettig
Copy link
Contributor Author

I believe I am all done. I have addressed the above comments either to the best that I can or to the limit that I want.

@abhay
Copy link
Contributor

abhay commented Jun 15, 2023

Excellent! Let's get it into discussion today.

@KeithRettig
Copy link
Contributor Author

Excellent! Let's get it into discussion today.

I asked this a long time ago...I don't know what that means or entails. Excited for it though!

@hiptron hiptron merged commit 71ce9cb into helium:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants