Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-xxxx: Payment Notes #117

Merged
merged 6 commits into from
Jan 29, 2021
Merged

HIP-xxxx: Payment Notes #117

merged 6 commits into from
Jan 29, 2021

Conversation

cvolkernick
Copy link
Contributor

This is a proposal I've watched get knocked around the discord in various forms for awhile now. Figured I'd make it an official proposal and gather feedback from the community.

@cvolkernick cvolkernick changed the title cvolkernick/payment notes HIP-xxxx: Payment Notes Jan 24, 2021
@jamiew
Copy link
Contributor

jamiew commented Jan 25, 2021

Will review this evening and let you know if any changes needed prior to merging

@cvolkernick
Copy link
Contributor Author

Thanks @jamiew you the real MVP

@jamiew jamiew added the draft label Jan 26, 2021
@PaulVMo
Copy link
Contributor

PaulVMo commented Jan 27, 2021

Couple thoughts here:

  1. If messages are on chain, I think you will not see a lot of adoption. For example, if I want to connect with a nearby hotspot owner, I would probably be looking to message them with my contact info to coordinate directly. However, I am unlikely to put my contact info on the public chain.
  2. as an alternative, I could see this as a capability of the wallet app which can be handled off chain (I think there is a precedent for that with whatever messaging is used for the exchanging the partial transfer transactions). Almost all owners currently use the app. With it going open source, there is an opportunity to push for features to be added. The only drawback I see is that it arguably should be an opt-in feature which means you still may not be able to contact the person you want to.

@jamiew
Copy link
Contributor

jamiew commented Jan 29, 2021

Looks good enough to merge for discussion. Stand by for tracking issue

@jamiew jamiew mentioned this pull request Jan 29, 2021
@jamiew jamiew merged commit 2e5f8ca into helium:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants