Skip to content

Conversation

simo5
Copy link
Contributor

@simo5 simo5 commented May 14, 2020

Fixes #210

@simo5 simo5 requested a review from frozencemetery May 14, 2020 21:31
@simo5 simo5 force-pushed the basic_timeout branch 4 times, most recently from 91d807c to c325ca7 Compare May 14, 2020 22:07
Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second commit has a typo - should be "distcheck".

Three things inline; otherwise looks good.

@simo5 simo5 force-pushed the basic_timeout branch 2 times, most recently from 8909040 to 3da01f0 Compare May 15, 2020 16:25
@simo5 simo5 requested a review from frozencemetery May 15, 2020 16:26
@simo5 simo5 dismissed frozencemetery’s stale review May 15, 2020 16:26

changed code to be more correct

simo5 added 3 commits May 15, 2020 13:24
Signed-off-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Robbie Harwood <rharwood@redhat.com>
Signed-off-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Robbie Harwood <rharwood@redhat.com>
Adds new option and tests.
Adds optional dependency on libfaketime to test this feature.

Fixes: gssapi#210
Signed-off-by: Simo Sorce <simo@redhat.com>
Merges: gssapi#217
Reviewed-by: Robbie Harwood <rharwood@redhat.com>
@frozencemetery frozencemetery merged commit 09df758 into gssapi:master May 15, 2020
frozencemetery pushed a commit to frozencemetery/mod_auth_gssapi that referenced this pull request Oct 30, 2020
Adds new option and tests.
Adds optional dependency on libfaketime to test this feature.

Fixes: gssapi#210
Signed-off-by: Simo Sorce <simo@redhat.com>
Merges: gssapi#217
Reviewed-by: Robbie Harwood <rharwood@redhat.com>
(cherry picked from commit 09df758)
[rharwood@redhat.com: git got confused by not having localname test]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Basic auth expires after 10 minutes

2 participants