Fix gss_localname #215
Fix gss_localname #215
Conversation
|
@alejandro-perez PTAL (your patch cause regression :) |
|
Built it and ran it in my dev environment, works. |
|
Will take a look tomorrow, thanks for the heads-up |
There was a problem hiding this comment.
Code looks good. I assume you plan to squash before merging, since right now you've got the test code split between both commits (.travis.sh is in the first one, but should be in the second if it's to be kept as two). You've also committed from an email that github doesn't know (the samba one) - might want to either change that email or add it to the ones github does know so the commits get associated with your account properly.
This fixes a regression introduced with commit: 9c555e2 Thanks to Matt Woodyard for patient help in debugging this issue. Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Simo Sorce <simo@redhat.com>
|
@frozencemetery I fixed the .travis.sh issue, I kept the commits separate so you can see that the test fail for SPNEGO only if you revert just the fix commit |
|
FWIW, it works fine with GSS-EAP, which was the motivation for making the change in the first place. |
4 participants
Commit 9c555e2 regressed this interface.
This PR fixes it and adds a test to make sure it stays fixed.
We have to use curl because apparently request_gssapi is not always doing that.